The android-check job failed on a tree that is perfectly correct:
android.rs exports three `Java_..._MainActivity_*` symbols, the check
compared all three against a single expected name and called it a
mismatch.
Two bugs, both from assuming one native:
- SYM collected every export while EXPECTED was built from one method, so
the comparison was three lines against one.
- The Kotlin side matched `external fun name()` on empty parens, which
quietly skipped nativeSetActivity and nativeBluetoothStateChanged —
parameters do not appear in the symbol name, so stop at the paren.
Now both sides are collected into sets and diffed, so a native declared
in Kotlin with no Rust half fails as loudly as the reverse. Verified
against the real files: passes as-is, and fails with a readable diff for
a Kotlin-only native and for a renamed Rust export.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The same leak we just closed on JellyTau, fed harder from here. `target/`
is 30 GB locally (25G debug, 3.1G android, 2.9G release) and was cached
under two keys across five jobs, on the runner both repos share.
- Cache registry/index, registry/cache and git/db only. registry/src is
left out as well: 155 MB of .crate tarballs beats 1.1 GB extracted, and
cargo re-extracts it for free. Verified that `cargo fetch` unpacks, so
sync-android-sources.sh — which reads btleplug's Java backend out of
registry/src before any build has run — still finds its sources.
- Collapse cargo-host and cargo-android into one cargo-registry key. The
split only existed to keep the two `target` dirs off each other; with
target uncached, registry contents are target-independent. This also
ends a silent miss: build-release's `test` and `build-linux` jobs shared
cargo-host, so the test job claimed the key and build-linux's cache was
never saved.
- CARGO_INCREMENTAL=0. Never reused between runs, and the bulk of the
25 GB debug dir.
- npm: cache ~/.npm instead of ui/node_modules. `npm ci` deletes
node_modules before installing, so that entry was restored and thrown
away unread.
- Installer artifact retention 30d -> 7d; the tagged release carries them.
Rust jobs now compile cold every run. sccache with a hard size cap is the
way back if that starts to hurt.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Two builder images, because the jobs genuinely need two distributions:
Ubuntu for the tests, the Linux bundle and the Android APK, and Arch for
the .pkg.tar.zst, since makepkg is Arch-specific. Both are built from
this repo (NFR-12) and pinned by tag in the workflows, so a Dockerfile
change only reaches CI once it has been pushed.
libdbus-1-dev is not incidental in the Ubuntu image: btleplug's Linux
backend is bluez-async over the dbus crate, so without it the workspace
does not build at all.
The per-commit Android job is a cargo check, not an APK. The full signed
build is ~15 minutes and runs only on tags; a one-minute check catches
what actually breaks — the JNI shim, droidplug, and any desktop-only API
that has crept into a shared crate.
Two invariants a compiler cannot see are checked there too, because both
fail silently: the app builds, installs, launches, and finds no trainer.
The JNI symbol in android.rs is matched by the runtime by name, so
renaming the Kotlin package compiles fine and simply never initialises
btleplug; and gen/ must stay untracked or the sync script quietly becomes
optional.
The Android versionCode carries a 1000 floor. `tauri android init` writes
1000 for 0.1.0 today, so anyone holding a locally built APK already has
that number installed, and a bare major/minor/patch code would be 100 —
a downgrade, which Android refuses outright.
The fmt check is advisory for now. The tree predates this workflow and
`cargo fmt --all` currently rewrites ~2000 lines across 28 files; making
it a gate here would mean landing a repo-wide reformat as a side effect
of adding CI. Run fmt in its own commit, then drop the continue-on-error.
The two clippy warnings that stood between the tree and a real
`-D warnings` gate are fixed.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
dtourolleandClaude Opus 5