Test the guard, since the bug was a branch nobody ran

The catalog clobber existed because `if let Ok(bytes)` had a failure arm that was never exercised. Fixing it without covering that arm leaves the next person free to collapse it back. Three tests against a backend whose read fails in a chosen way, counting writes — because what went wrong was not a wrong value but a write that should not have happened at all: - a dehydrated snapshot uploads nothing - an unreadable one uploads nothing either, since "refused" is no more "absent" than "not downloaded" is - and a genuine first sync still uploads, which is the half that keeps `NotFound` distinct from `NotMaterialised` rather than merely cautious Checked against the original shape: the first two fail on it and the third passes. A guard test that cannot tell the bug from the fix is decoration. `async-trait` joins dev-dependencies to stand the double up behind `dyn RemoteBackend`.
2026-08-29 10:40:38 +02:00
parent 4168d67cfa
commit 21d599b420
3 changed files with 166 additions and 0 deletions
@@ -120,3 +120,6 @@ live-style = ["dep:serde_norway"]
 # The face_index batch job wants a log level from the environment; the library
 # itself only ever calls `log`, and picks up whatever the application installs.
 env_logger.workspace = true
+# Standing in a test backend behind `dyn RemoteBackend`, which is an
+# `#[async_trait]` trait — implementing one needs the same attribute.
+async-trait.workspace = true