Write down the develop gestures, since only their author knew them
FR-UI-4 says a gesture with no visible counterpart is a feature only its author knows about, and the vocabulary the application actually publishes had two sections in it — the library grid and people. Develop had none. Every one of its gestures was documented in the comment beside the `TouchArea` that implements it, which is where the previous sixteen were before this scanner existed, and unreachable to anybody not reading the source. Thirteen now carry tags: magnify by pinch or wheel, pan a magnified frame, fit and 1:1, hold to see the original, sample a neutral, undo and redo, step through the folder, reset one control, show or hide a mask layer, choose a group of adjustments, and copy and paste the settings. Each has a pointer and a touch route, so none of them is keyboard-only. Three bindings were genuinely missing and are added here rather than merely described. Ctrl+C and Ctrl+V for the settings clipboard, which the Settings panel's own comment has claimed existed for as long as the panel has and nothing bound; and [ and ] to step through the adjustment groups. The groups are whatever the operation set declares itself to be about, so there are as many as the pipeline has and no key can name one of them — stepping is the binding that survives a node being added, and "everything" is part of the cycle rather than a way out of it. Two are described and not bound. Resetting a control from the keyboard and toggling a mask layer from the keyboard both need a notion of which control or layer has focus, and the generated panel has none — the rows are a model the repeater rebuilds, and inventing a focus ring for them is a larger change than a keyboard shortcut. Both are reachable by pointer and by finger, and the tags say so rather than promising a key that is not there.
This commit is contained in:
@@ -1987,6 +1987,16 @@ in property <bool> panel-visible: true;
|
||||
// Below the crop overlay in z-order so that, in crop mode, the
|
||||
// handles take the drag instead. Scroll still zooms either way.
|
||||
|
||||
// GESTURE: Magnify the photograph by any amount
|
||||
// where: Develop
|
||||
// touch: Pinch it with two fingers
|
||||
// pointer: The scroll wheel over it
|
||||
// why: Anchored on the fingers' midpoint, and on the
|
||||
// pointer, so the gesture reads as magnifying
|
||||
// the picture rather than sliding it about.
|
||||
// Double-tap is the way to an exact 1:1; this
|
||||
// is the way to everything in between.
|
||||
//
|
||||
// TRACES: FR-UI-4
|
||||
// Pinch to zoom. The wheel gesture below is the desktop's
|
||||
// answer and there is no wheel on a tablet, so without this
|
||||
@@ -2130,6 +2140,18 @@ in property <bool> panel-visible: true;
|
||||
}
|
||||
}
|
||||
|
||||
// GESTURE: Move a magnified photograph about
|
||||
// where: Develop
|
||||
// touch: Drag it
|
||||
// pointer: Drag it
|
||||
// why: Only once there is something outside the
|
||||
// viewport to reach, which is why the
|
||||
// cursor becomes a hand exactly then. The
|
||||
// view is clamped to the frame: panning
|
||||
// past the edge would show undefined area
|
||||
// beside the photograph, and that reads as
|
||||
// a rendering fault rather than as the end
|
||||
// of the picture.
|
||||
moved => {
|
||||
if (self.pressed && root.zoomed) {
|
||||
// Fractions of the *visible* area, which is what
|
||||
@@ -2285,6 +2307,27 @@ in property <bool> panel-visible: true;
|
||||
root.compare-original(true);
|
||||
return accept;
|
||||
}
|
||||
// GESTURE: Take back the last change
|
||||
// where: Develop
|
||||
// touch: Tap the step above the current one in
|
||||
// the History list
|
||||
// pointer: Click it, or press Undo in the
|
||||
// History header
|
||||
// keys: Ctrl+Z
|
||||
// why: A whole drag is one step, so undo
|
||||
// takes back a decision rather than a
|
||||
// frame of a gesture. The list is there
|
||||
// because arriving six steps back costs
|
||||
// what arriving from one does.
|
||||
//
|
||||
// GESTURE: Do it again after taking it back
|
||||
// where: Develop
|
||||
// touch: Tap the step below the current one in
|
||||
// the History list
|
||||
// pointer: Click it, or press Redo in the
|
||||
// History header
|
||||
// keys: Ctrl+Shift+Z
|
||||
//
|
||||
// Ctrl+Z and Ctrl+Shift+Z (FR-DEV-5). Both cases
|
||||
// of the letter, because the logical key that
|
||||
// reaches us carries the shift: holding it for
|
||||
@@ -2310,6 +2353,100 @@ in property <bool> panel-visible: true;
|
||||
root.spot-removed(root.selected-spot);
|
||||
return accept;
|
||||
}
|
||||
// GESTURE: Copy the settings from this photograph
|
||||
// where: Develop
|
||||
// touch: Press Copy in the Settings panel
|
||||
// pointer: Press Copy in the Settings panel
|
||||
// keys: Ctrl+C
|
||||
// why: The panel is the copy that has to
|
||||
// work: a tablet has no modifier key
|
||||
// to hold and no menu bar to hang the
|
||||
// action from. The shortcut is an
|
||||
// accelerator for a control that is on
|
||||
// screen either way.
|
||||
//
|
||||
// GESTURE: Paste the settings onto this photograph
|
||||
// where: Develop
|
||||
// touch: Press Paste in the Settings panel
|
||||
// pointer: Press Paste in the Settings panel
|
||||
// keys: Ctrl+V
|
||||
// why: The button names what would be
|
||||
// pasted — "3 adjustments", and
|
||||
// whether the crop is coming with it —
|
||||
// which the shortcut cannot say. Both
|
||||
// paste the same scope.
|
||||
//
|
||||
// TRACES: FR-DEV-6
|
||||
// The desktop accelerators for the two buttons in
|
||||
// the Settings panel, which until now the panel's
|
||||
// own comment claimed existed and nothing bound.
|
||||
// Guarded on `settings-armed` for the reason the
|
||||
// button is: a paste with nothing copied is not a
|
||||
// clear, it is a keystroke that should do nothing.
|
||||
if (event.modifiers.control
|
||||
&& (event.text == "c" || event.text == "C")) {
|
||||
root.copy-settings();
|
||||
return accept;
|
||||
}
|
||||
if (event.modifiers.control && root.settings-armed
|
||||
&& (event.text == "v" || event.text == "V")) {
|
||||
root.paste-settings();
|
||||
return accept;
|
||||
}
|
||||
// GESTURE: Change which group of adjustments is on screen
|
||||
// where: Develop
|
||||
// touch: Tap a group in the rail down the left
|
||||
// pointer: Click a group in the strip above the
|
||||
// develop column
|
||||
// keys: [ and ] step through them, wrapping
|
||||
// round through "everything"
|
||||
// why: The groups are whatever the operation
|
||||
// set declares itself to be about, so
|
||||
// there are as many as the pipeline has
|
||||
// and no key can be assigned to one of
|
||||
// them by name. Stepping is the binding
|
||||
// that survives a node being added.
|
||||
//
|
||||
// TRACES: FR-DEV-3a | FR-UI-5
|
||||
// -1 is "everything" and is part of the cycle
|
||||
// rather than a way out of it: it is where the
|
||||
// panel starts, so a photographer stepping round
|
||||
// the groups arrives back at the whole set instead
|
||||
// of being trapped in the last one.
|
||||
if (event.text == "]") {
|
||||
root.adjust-tab-picked(
|
||||
(root.adjust-active-tab + 1
|
||||
>= root.adjust-tabs.length)
|
||||
? -1
|
||||
: (root.adjust-active-tab + 1));
|
||||
return accept;
|
||||
}
|
||||
if (event.text == "[") {
|
||||
root.adjust-tab-picked(
|
||||
(root.adjust-active-tab - 1 < -1)
|
||||
? (root.adjust-tabs.length - 1)
|
||||
: (root.adjust-active-tab - 1));
|
||||
return accept;
|
||||
}
|
||||
// GESTURE: Look at the photograph at 1:1
|
||||
// where: Develop
|
||||
// touch: Double-tap the photograph
|
||||
// pointer: Double-click it, or press the zoom
|
||||
// readout floating over the canvas
|
||||
// keys: Z
|
||||
// why: Noise reduction and capture
|
||||
// sharpening are judgements about
|
||||
// single pixels, and a fitted view
|
||||
// averages several of the file's into
|
||||
// each one on screen — so the frame
|
||||
// looks softer than it is and the
|
||||
// correction goes too far. The point
|
||||
// and the magnification survive opening
|
||||
// the next photograph, which is what
|
||||
// makes checking the same eye across
|
||||
// forty portraits forty keystrokes
|
||||
// rather than forty pans.
|
||||
//
|
||||
// TRACES: FR-UI-4 | FR-UI-5
|
||||
// Fit and 1:1 from the keyboard, so inspecting
|
||||
// forty portraits at the same eye is forty
|
||||
@@ -2321,6 +2458,17 @@ in property <bool> panel-visible: true;
|
||||
root.inspect-toggled(-1, -1);
|
||||
return accept;
|
||||
}
|
||||
// GESTURE: Move to the next or previous photograph
|
||||
// where: Develop
|
||||
// touch: Tap a frame in the roll along the
|
||||
// foot of the canvas
|
||||
// pointer: Click a frame in the roll
|
||||
// keys: Right arrow or space for the next,
|
||||
// left arrow for the one before
|
||||
// why: The edit on screen is saved on the
|
||||
// way out, so stepping through a folder
|
||||
// is as much a departure as going back
|
||||
// to the grid and loses nothing.
|
||||
if (event.text == Key.RightArrow || event.text == " ") {
|
||||
root.next-image();
|
||||
return accept;
|
||||
@@ -2434,6 +2582,20 @@ in property <bool> panel-visible: true;
|
||||
clicked => { root.inspect-toggled(-1, -1); }
|
||||
}
|
||||
|
||||
// GESTURE: See the photograph before you edited it
|
||||
// where: Develop
|
||||
// touch: Press and hold "Before"
|
||||
// pointer: Press and hold "Before"
|
||||
// keys: Hold \
|
||||
// why: Held rather than toggled, and no split
|
||||
// screen: a split halves the working image
|
||||
// on the tablet the column was sized for,
|
||||
// and the comparison photographers describe
|
||||
// making is a flick back and forth. It
|
||||
// takes no history step, so checking
|
||||
// whether a frame is overcooked costs
|
||||
// nothing to undo afterwards.
|
||||
//
|
||||
// TRACES: FR-DEV-7 | FR-DEV-3b | NFR-A11Y-2
|
||||
// The unedited original, for as long as it is held.
|
||||
//
|
||||
|
||||
Reference in New Issue
Block a user