cargo fmt and clippy across the panorama work, and one lint master carried

The dr-face comparison is master's: a negated partial-order test on the
eye box's width, rewritten as the two conditions it meant.

core/dr-export/src/dng.rs

@@ -65,6 +65,10 @@ pub struct DngProfile {
 /// rectangle the frames covered, found while the strips went by
 /// (`Inscribed`) — becomes `DefaultCropOrigin`/`DefaultCropSize`
 /// (FR-MRG-4): the file opens on the picture, and the border is still in it.
+// Eight arguments, and each is a different thing: the sink, three
+// dimensions, the profile, the header, the strip source and the crop. A
+// struct for them would be a struct with one caller.
+#[allow(clippy::too_many_arguments)]
 pub fn write_linear_dng<W, F, C>(
     out: W,
     width: u32,
@@ -119,7 +123,10 @@ where
             .map_err(enc)?;
         image
             .encoder()
-            .write_tag(Tag::Unknown(tag::DEFAULT_CROP_SIZE), &[r.width, r.height][..])
+            .write_tag(
+                Tag::Unknown(tag::DEFAULT_CROP_SIZE),
+                &[r.width, r.height][..],
+            )
             .map_err(enc)?;
     }
     image.finish().map_err(enc)
@@ -136,8 +143,14 @@ where
     dir.write_tag(Tag::Orientation, 1u16)?;
     dir.write_tag(Tag::Unknown(tag::DNG_VERSION), &[1u8, 4, 0, 0][..])?;
     dir.write_tag(Tag::Unknown(tag::DNG_BACKWARD_VERSION), &[1u8, 4, 0, 0][..])?;
-    dir.write_tag(Tag::Unknown(tag::UNIQUE_CAMERA_MODEL), Ascii(&profile.unique_model))?;
-    dir.write_tag(Tag::Unknown(tag::WHITE_LEVEL), &[profile.white_level; 3][..])?;
+    dir.write_tag(
+        Tag::Unknown(tag::UNIQUE_CAMERA_MODEL),
+        Ascii(&profile.unique_model),
+    )?;
+    dir.write_tag(
+        Tag::Unknown(tag::WHITE_LEVEL),
+        &[profile.white_level; 3][..],
+    )?;
     dir.write_tag(Tag::Unknown(tag::BLACK_LEVEL), &[0u32; 3][..])?;
 
     for (slot, (illuminant, matrix)) in profile.calibrations.iter().take(2).enumerate() {
@@ -281,7 +294,7 @@ mod tests {
         let i = (12 * 20 + 19) * 3;
         assert_eq!(data[i], (19 + 12 * 20) as u16);
         // The profile came through as the camera's.
-        assert!(image.camera.color_matrix.len() >= 1);
+        assert!(!image.camera.color_matrix.is_empty());
         assert_eq!(image.model, "Canon EOS 6D");
         // The default crop is what the decoder reports as the picture.
         let crop = image.crop_area.expect("a crop");

core/dr-export/src/inscribed.rs

@@ -126,12 +126,7 @@ mod tests {
     fn ragged_edges_are_cut_off() {
         // A cylinder's footprint: narrower at top and bottom.
         let r = from_art(&[
-            "..####..",
-            ".######.",
-            "########",
-            "########",
-            ".######.",
-            "..####..",
+            "..####..", ".######.", "########", "########", ".######.", "..####..",
         ]);
         // 6 wide × 4 tall = 24 beats 8 × 2 = 16 and 4 × 6 = 24 ties; the
         // first found wins a tie, which is the wider one here.

core/dr-export/src/lib.rs

@@ -26,18 +26,18 @@ use dr_types::{ColourSpace, ExportFormat, ExportSettings};
 
 mod dng;
 mod encode;
-mod inscribed;
 mod error;
 mod exif;
 pub mod icc;
+mod inscribed;
 mod metadata;
 mod name;
 mod sharpen;
 mod size;
 
 pub use dng::{write_linear_dng, DngProfile};
-pub use inscribed::{Inscribed, Rect};
 pub use error::ExportError;
+pub use inscribed::{Inscribed, Rect};
 pub use metadata::SourceMetadata;
 pub use name::{resolve_name, NameContext};
 pub use size::target_size;