Let Compose lead the attributes, as their own doc always said
`Attribute::ALL` claims to be "roughly the order a photographer works in" and then listed framing fifth, behind tone, colour and detail. Framing is the first decision made about a photograph and the one every later judgement is made inside — there is no sense balancing tones across a frame about to lose a third of its width. The contradiction was harmless while the list only fed a row of chips nobody reads in order. It stops being harmless now that the same list drives a column read top to bottom. `declared::Attr::ALL` moves with it. The two are separate spellings of one vocabulary and a test asserts they agree, which is what caught this rather than the order silently disagreeing between the YAML front end and the crate. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -140,11 +140,11 @@ impl Attr {
|
||||
/// Every attribute, in the order `crate::descriptor::Attribute` declares
|
||||
/// them.
|
||||
pub const ALL: [Attr; 6] = [
|
||||
Attr::Compose,
|
||||
Attr::Tone,
|
||||
Attr::Colour,
|
||||
Attr::Detail,
|
||||
Attr::Optics,
|
||||
Attr::Compose,
|
||||
Attr::Effect,
|
||||
];
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user