From 721efbc3718252fdda378b9c85c48a06a8eb8e93 Mon Sep 17 00:00:00 2001 From: Duncan Tourolle Date: Thu, 27 Aug 2026 12:16:17 +0200 Subject: [PATCH] Drop three trait imports Android does not need The Linux store is built on `keyring::Entry`, whose set_password, get_password and delete_credential are inherent methods. The Android one is built on `keyring_core::Entry`, where they are inherent too -- so the `CredentialApi` import that each of its three methods opened with was doing nothing, and said so on every Android build. `CredentialStoreApi` a few lines above is a different matter and stays: `build` really does come from that trait. Co-Authored-By: Claude Opus 5 (1M context) --- platform/dr-plat/src/secrets.rs | 6 ------ 1 file changed, 6 deletions(-) diff --git a/platform/dr-plat/src/secrets.rs b/platform/dr-plat/src/secrets.rs index ef2bb0b..ffe07c5 100644 --- a/platform/dr-plat/src/secrets.rs +++ b/platform/dr-plat/src/secrets.rs @@ -222,22 +222,16 @@ impl Default for PlatformSecretStore { #[cfg(target_os = "android")] impl SecretStore for PlatformSecretStore { fn store(&self, secret_ref: &SecretRef, secret: &str) -> Result<(), SecretError> { - use keyring_core::api::CredentialApi; - self.entry(secret_ref)? .set_password(secret) .map_err(map_err) } fn retrieve(&self, secret_ref: &SecretRef) -> Result { - use keyring_core::api::CredentialApi; - self.entry(secret_ref)?.get_password().map_err(map_err) } fn delete(&self, secret_ref: &SecretRef) -> Result<(), SecretError> { - use keyring_core::api::CredentialApi; - match self.entry(secret_ref)?.delete_credential() { Ok(()) => Ok(()), // Logout must be idempotent, as on Linux.