Start every worker thread through the executors module
Thirty-nine spawn sites in dr-ui, and one in the Android entry point, called std::thread::spawn or a Builder of their own, and most of the threads they started were <unnamed> in a panic message or a profiler. Each now calls executors::spawn with its executor and a role, so the thread is named <executor>:<role> — net:sync, decode:thumbs, io:catalog-open — and knows which executor it is on. The three that already set a name (automation, import, prefetch) keep their name as the role. Behaviour is unchanged: each job still gets a thread of its own when it starts, and spawn panics where std::thread::spawn did. The module's documentation now says how a job is assigned: by what it spends its time on, so a sweep that fetches bytes and then decodes them is Decode, and a sidecar write that touches the catalog is Network. Left as they were: the segmentation and refine workers in masks_ui.rs, which another change is reworking, and test-only threads.
This commit is contained in:
@@ -8,6 +8,7 @@
|
||||
//! (`offline`) it hands off to on a failure. See `docs/dev/code-health.md`
|
||||
//! CH-1.
|
||||
|
||||
use crate::executors::{self, Executor};
|
||||
use std::path::PathBuf;
|
||||
use std::rc::Rc;
|
||||
use std::sync::mpsc::Receiver;
|
||||
@@ -271,7 +272,7 @@ enum CatalogOpen {
|
||||
fn spawn_catalog_open(path: PathBuf) -> Receiver<CatalogOpen> {
|
||||
let (tx, rx) = std::sync::mpsc::channel();
|
||||
|
||||
std::thread::spawn(move || {
|
||||
executors::spawn(Executor::Io, "catalog-open", move || {
|
||||
let started = std::time::Instant::now();
|
||||
let message = match Catalog::open_verified(&path) {
|
||||
Ok(cat) => {
|
||||
|
||||
Reference in New Issue
Block a user