Count the same images in the progress figure that the sweeps index
The Identity screen said 4,593 images were left to index and stayed there for hours across repeated runs, which is what a stuck job looks like. It was not stuck. 4,424 of those 4,593 are shadowed -- the JPEG half of a RAW+JPEG pair -- and no sweep will ever index one, because every work list is built on VISIBLE, which excludes them. They are not separate photographs and the grid does not show them either. But faces::coverage counted them: its denominator was "images WHERE trashed_at IS NULL", with no shadowed_by clause. So the outstanding figure had a floor of 4,424 that no amount of work could bring down, and Coverage::is_complete could never once return true no matter how completely the library had been indexed. A progress number that cannot reach its own target is worse than no progress number. The fix is to count the population the sweeps actually draw from, in all three places that were describing it differently: coverage's denominator and its indexed join, and audit's split of the outstanding set, which had the same gap and fed the same status line. On the reference library the denominator goes from 23,531 to 19,107 and outstanding from 4,593 to 169 -- the second of which is a number the user can watch go down, and which turns out to be a real and separate fetch failure worth chasing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -82,6 +82,7 @@ pub fn faces_outstanding(
|
||||
JOIN remote r ON r.image_id = i.id
|
||||
WHERE r.file_id IS NOT NULL
|
||||
AND i.trashed_at IS NULL
|
||||
AND i.shadowed_by IS NULL
|
||||
AND NOT EXISTS (
|
||||
SELECT 1 FROM face_index fi
|
||||
WHERE fi.image_id = i.id AND fi.model_id = ?1
|
||||
@@ -177,13 +178,17 @@ pub fn audit(
|
||||
|
||||
// Split the outstanding set by whether a proxy exists. This is the query
|
||||
// `faces_outstanding` runs without the store filter, so the two cannot
|
||||
// disagree about what is outstanding.
|
||||
// disagree about what is outstanding. Shadowed images are excluded here
|
||||
// for the same reason `faces::coverage` excludes them: they are the JPEG
|
||||
// half of a pair, no sweep will ever index one, and counting them makes
|
||||
// the outstanding figure a number that cannot reach zero.
|
||||
let mut stmt = conn.prepare(
|
||||
"SELECT r.file_id
|
||||
FROM images i
|
||||
JOIN remote r ON r.image_id = i.id
|
||||
WHERE r.file_id IS NOT NULL
|
||||
AND i.trashed_at IS NULL
|
||||
AND i.shadowed_by IS NULL
|
||||
AND NOT EXISTS (
|
||||
SELECT 1 FROM face_index fi
|
||||
WHERE fi.image_id = i.id AND fi.model_id = ?1
|
||||
|
||||
Reference in New Issue
Block a user