From d2b99bb8c12ded2d7b4d6cbbbadbd9630797d596 Mon Sep 17 00:00:00 2001 From: Duncan Tourolle Date: Sat, 26 Sep 2026 14:57:35 -0400 Subject: [PATCH] Note the folder dialogues in windows.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Since 6683c14 every folder on the desktop is chosen through rfd, which on Windows is the common item dialogue. windows.md's list of what is already handled now says so, and that nothing has opened one under Wine or on Windows. "The import flow's path picker" is now the import page's Browse… button. --- docs/dev/windows.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/docs/dev/windows.md b/docs/dev/windows.md index b61fa7c..82abaad 100644 --- a/docs/dev/windows.md +++ b/docs/dev/windows.md @@ -130,8 +130,13 @@ in `core/` is touched, which is NFR-PORT-1 holding. - **`volumes.rs`** — card detection reads `/proc/mounts` and `/sys/block` under `cfg(target_os = "linux")` and returns an empty list elsewhere. Windows gets no card detection - in this pass; the import flow's path picker still works. (A `GetDriveType`/`DRIVE_REMOVABLE` + in this pass; the import page's `Browse…` still reaches a card. (A `GetDriveType`/`DRIVE_REMOVABLE` implementation is a screen of code and a follow-up.) +- **Folder dialogues** — since 0.17.0 every folder the desktop asks for (the library, an import's + source and second copy, Lightroom presets, an album's folder) is chosen in the platform's own + dialogue through `rfd` ([`folder_dialog.rs`](../../ui/dr-ui/src/folder_dialog.rs)), which on + Windows is the common item dialogue rather than the XDG portal. *Not verified*: nothing has + opened one under Wine or on Windows. - **`display.rs`** — the X11 and Wayland colour-profile readers are `cfg(all(unix, not(android)))`; the fallback is FR-DSP-8's stated one. Windows ICC profiles via `GetICMProfile` are a follow-up for the same reason.