Drive develop, the grid, the sidebar and People from the keyboard

An audit of every action by view against the keys the handlers bind left
develop without zoom, pan, fit or a way back to the grid, the grid without
select-none, thumbnail size or keywording, People with no key at all, and
the export and copy sheets without Enter. It also found the reverse gap
FR-UI-5 forbids: pick and reject had no route but P, X and U, and the
2026-09-19 amendment's judging in develop had not been built.

Develop: Ctrl+= and Ctrl+Plus zoom in and Ctrl+- out about the middle of the
view, Ctrl+0 fits and Ctrl+1 goes to 1:1, Shift and an arrow pan a magnified
view, G goes back to the grid, Ctrl+Y redoes, and Enter keeps a crop that hid
a mask. 0-5, P, X and U rate and flag the open photograph without moving on,
with stars and Pick/Reject in the top bar as the pointer and touch route.
= and - nudge the control last moved by a hundredth of its travel; the
framing sliders, perspective included, now count as "last moved", so R puts
them back as well. J turns the selected mask part's join chip.

Grid: Ctrl+D and Ctrl+Shift+A clear the selection, = and - resize the
thumbnails, Ctrl+K opens keywording, and Flag in the selection bar gives
pick and reject a pointer and touch route. Sidebar: Enter commits a
collection's name, and Enter or Escape hands the keyboard back to the grid,
where it used to go nowhere until something was clicked. People: Up and Down
walk the rail, F2 puts the name field under the keys, and Escape or Back now
leave the screen the way its back button does instead of doing nothing.
Sheets: Enter does what the export or copy sheet's button does.

The choices follow Lightroom where it has one. No new key steals typing: the
grid's and People's keys live on focus holders that are not ancestors of any
text field, and the sheets' Enter comes after a focused field has had it.
Every binding is tagged beside its handler, and the gate added in the
previous commit holds the two to each other.
This commit is contained in:
2026-09-24 23:42:26 -04:00
parent 9d1e31ffbb
commit d489a34190
15 changed files with 975 additions and 160 deletions
+9 -10
View File
@@ -448,6 +448,7 @@ fn reset_view_state(window: &AppWindow) {
// would land on whichever control happens to share them.
window.global::<Adjustments>().set_touched_op(-1);
window.global::<Adjustments>().set_touched_param(-1);
window.global::<Framing>().set_touched(0);
// TRACES: FR-DSP-7
// Emptied rather than left standing: the previous photograph's histogram
// beside the next one's filename is a confident, precise lie, and the gap
@@ -3433,19 +3434,17 @@ fn apply_layout_class(
/// the activity — the behaviour every application there has, and the reason
/// this answers with a bool rather than swallowing the gesture.
fn back_one_step(w: &AppWindow) -> bool {
// TRACES: FR-UI-5 | FR-UI-4
// The Identity screen has no representation in `NavState`: nothing here
// records which view it replaced, only `identity_ui`'s own
// `came_from_library`, which this function has no reason to reach for
// over one screen. Before this refactor, back queued nothing behind
// Identity opened from the library (show-library stayed true, unread by
// anything) and queued `ToLibrary` behind Identity opened from develop —
// but `ToLibrary` only ever set `show-library`, a property
// `IdentityScreen`'s own `if` never read, so both cases looked the same
// on screen: nothing happened. Swallowing the gesture here keeps that:
// falling into the general case below would instead write `active-view`,
// which `IdentityScreen`'s `if` *does* read, and close the screen as a
// side effect nobody asked for.
// `came_from_library`. So back leaves it the way its own "‹ Library" /
// "‹ Develop" button does, through `identity-close`, which knows where it
// came from — rather than through the general case below, which would
// write `active-view` without that knowledge. It used to swallow the key
// and do nothing, which left Escape and Android's Back dead on a whole
// screen.
if w.get_active_view() == View::Identity {
w.invoke_identity_close();
return true;
}