Turn face boxes back into sensor space before matching regions
Faces are found on the thumbnail, which is cached the right way up -- the grid would lie on its side otherwise. Segmentation runs on a proxy rendered through a neutral edit graph, which carries no orientation and is therefore in sensor order. For anything shot in portrait the two differ by a quarter turn, so a face and the person containing it were being compared in spaces 90 degrees apart: no match, or worse, a match against somebody else's region. The transform goes on the face rather than on the proxy. Instance masks are defined in the proxy's space and sampled long afterwards, so turning that space would be a far larger change than naming a region warrants. Also two things the first screenshot of the running app showed that no test would have: 110 of 23,528 displayed as "0%", which reads as the feature having done nothing. One decimal below ten percent, and a floor so real progress never shows as none. The rail picked some near-black covers, because the largest face in a group is often the nearest one in a badly lit frame and a black square beside a name identifies nobody. It now cuts the best few and takes the first legible one, falling back to the largest when a person's every photograph is dark -- which happens, and showing it beats showing nothing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -2031,6 +2031,13 @@ pub fn run(paths: Vec<PathBuf>) -> Result<()> {
|
||||
|
||||
masks_ui::wire(&window, &session, &rows, &redraw);
|
||||
|
||||
// A way to land on the Identity Manager at startup, for looking at it
|
||||
// without a mouse. Off unless the variable is set, so it costs a getenv
|
||||
// per launch and changes nothing otherwise.
|
||||
if std::env::var_os("DARKROOM_START_IDENTITY").is_some() {
|
||||
window.invoke_identity_open();
|
||||
}
|
||||
|
||||
{
|
||||
let weak = window.as_weak();
|
||||
let session = session.clone();
|
||||
|
||||
Reference in New Issue
Block a user