FR-DEV-6 — Copy rotation without the crop, and the crop without rotation #60

New Issue

2026-09-25T00:05:45Z

dtourolle commented

2026-09-25 00:05:45 +00:00

A paste can leave out crop and rotation together, but not rotation alone. The copy scope is by edit kind — Tone, Colour, Detail, Optics, Compose, Effect, from dr_pipeline::Attribute — and crop, rotation and straighten all sit under Compose.

Why

The usual shape of pasting a look across a shoot is "everything except the framing", and Compose off covers it. But a set shot on a tripod that was levelled once wants the straighten to travel and each frame's crop to stay, and the reverse happens after a batch crop to a print ratio. Neither can be said today. The Ctrl+Shift+C copy sheet (bddf325) now puts the choice at the moment of copying, which makes the gap more visible.

Decision needed

Splitting Compose is a change to the pipeline's attribute set, not to the UI: the chips are generated from Attribute::ALL and the stored scope is a list of attribute names. Options:

split Compose into Crop and Geometry (rotation, straighten, flip, perspective), migrating stored scopes that name compose to both;
or keep the attribute and add a finer, per-parameter exclusion only in the copy sheet.

The first keeps presets, paste and the settings page agreeing, which is why the scope is one thing today.

Acceptance

Rotation/straighten can travel without the crop, and the reverse
A stored scope from before the split keeps meaning what it meant
Presets, the copy sheet and the settings page show the same chips

**A paste can leave out crop and rotation together, but not rotation alone.** The copy scope is by edit kind — Tone, Colour, Detail, Optics, Compose, Effect, from `dr_pipeline::Attribute` — and crop, rotation and straighten all sit under Compose. ## Why The usual shape of pasting a look across a shoot is "everything except the framing", and Compose off covers it. But a set shot on a tripod that was levelled once wants the *straighten* to travel and each frame's *crop* to stay, and the reverse happens after a batch crop to a print ratio. Neither can be said today. The Ctrl+Shift+C copy sheet (bddf325) now puts the choice at the moment of copying, which makes the gap more visible. ## Decision needed Splitting Compose is a change to the pipeline's attribute set, not to the UI: the chips are generated from `Attribute::ALL` and the stored scope is a list of attribute names. Options: - split `Compose` into `Crop` and `Geometry` (rotation, straighten, flip, perspective), migrating stored scopes that name `compose` to both; - or keep the attribute and add a finer, per-parameter exclusion only in the copy sheet. The first keeps presets, paste and the settings page agreeing, which is why the scope is one thing today. ## Acceptance - [ ] Rotation/straighten can travel without the crop, and the reverse - [ ] A stored scope from before the split keeps meaning what it meant - [ ] Presets, the copy sheet and the settings page show the same chips

dtourolle added the develop pipeline size:M decision labels 2026-09-25 00:05:45 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dtourolle/DarkRoom#60