TextRow draws no label, on the settings page and in the export sheet #61

Closed
opened 2026-09-25 00:05:46 +00:00 by dtourolle · 1 comment
Owner

TextRow draws no label. "Filename template" and "Destination" have a field and a hint but no name, on the settings page and in the export sheet alike (Ctrl+E, bddf325), which reuse the same ExportFileOptions panel.

Why

A field with no name next to it is a field the user has to guess at; the hint beside "Destination" is the only thing saying what it is. Known since 0.9.0: the FieldRow draws behind the field rather than above it (visible as the clipped "ws" beside the thumbnail cache field in STORAGE). Segmented in the same files is fine, so it is TextRow, not the if around it, and alignment: start on the layout does not fix it.

Deliverable

TextRow in controls.slint laid out so its label renders above (or beside) the field, everywhere it is used.

Acceptance

  • "Filename template", "Destination" and the storage budget labels are visible on the settings page
  • The same labels are visible in the export sheet
  • Checked by screenshot (Xvfb rig), since the fault compiles clean
**`TextRow` draws no label.** "Filename template" and "Destination" have a field and a hint but no name, on the settings page and in the export sheet alike (Ctrl+E, bddf325), which reuse the same `ExportFileOptions` panel. ## Why A field with no name next to it is a field the user has to guess at; the hint beside "Destination" is the only thing saying what it is. Known since 0.9.0: the `FieldRow` draws *behind* the field rather than above it (visible as the clipped "ws" beside the thumbnail cache field in STORAGE). `Segmented` in the same files is fine, so it is `TextRow`, not the `if` around it, and `alignment: start` on the layout does not fix it. ## Deliverable `TextRow` in `controls.slint` laid out so its label renders above (or beside) the field, everywhere it is used. ## Acceptance - [ ] "Filename template", "Destination" and the storage budget labels are visible on the settings page - [ ] The same labels are visible in the export sheet - [ ] Checked by screenshot (Xvfb rig), since the fault compiles clean
dtourolle added the uisize:S labels 2026-09-25 00:05:46 +00:00
Author
Owner

Fixed in c559d31, released in v0.16.0. TextRow sized its field box from field.preferred-height, which is 0 for Field (it sets its height outright, with no layout inside), so the field centred itself half a field above the row, on top of its label. It now reads field.height. Checked by screenshot on the settings page (storage, files and metadata), the export sheet (including Width/Height) and import.

Fixed in c559d31, released in v0.16.0. `TextRow` sized its field box from `field.preferred-height`, which is 0 for `Field` (it sets its height outright, with no layout inside), so the field centred itself half a field above the row, on top of its label. It now reads `field.height`. Checked by screenshot on the settings page (storage, files and metadata), the export sheet (including Width/Height) and import.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dtourolle/DarkRoom#61