dtourolle
7421837c8a
Tool tabs need a taxonomy, and the taxonomy was the problem: a table in `ui/` mapping operation to tab breaks FR-DEV-3a, and a `group:` field risks what `ui-refinement.md` condemned `starts-group` for — the core deciding where the panel draws things. `Attribute` threads the needle. It says what an operation *is* — tone, colour, detail, optics, geometry, effect — which is the same category as `ParamKind` and squarely on the core's side of ARCH §4.3a's line. What is drawn, where it sits and whether it is visible stay the frontend's. There is no attribute for "the third tab", the enum's order is declaration order rather than screen order, and a frontend may render these as tabs, as headings, or ignore them. The payoff is that a tab strip can be *derived*: the groups are the attributes present in the capability list, so the interface names no operation and needs no table to keep in step. An operation joins the right group by declaring what it is, which is the one thing its author is well placed to say. Plural, because the tone curve is genuinely both — an RGB curve is tonal and the per-channel curves are chromatic, and filing it under one would hide it from half the people looking for it. Required and non-empty, enforced in `build.rs`, and the failure was checked by removing the line rather than assumed. An operation with no attribute is invisible to a panel that groups by them; a build that stops costs ten seconds, a control nobody can find costs more. The vocabulary is closed for the same reason: a typo would otherwise invent a category holding exactly one operation, which looks like a deliberate one until somebody counts. Six tests over the real chain, including the hand-written operations that `build.rs` never sees and so cannot check.
29 lines
1.3 KiB
YAML
29 lines
1.3 KiB
YAML
# A hand-written node. `rust:` names the type in `crate::ops` that implements
|
|
# `Operation`; everything else about it — its descriptor, its parameters, its
|
|
# WGSL — comes from that type rather than from this file.
|
|
#
|
|
# It appears here anyway so that `ops/` lists the whole pipeline in order.
|
|
# A chain half-declared here and half-ordered in Rust would be worse than
|
|
# either alone: the order is the one thing a reader comes to this directory
|
|
# to learn.
|
|
id: tone_curve
|
|
order: 60
|
|
|
|
# Both, and this is the case the plural exists for: the RGB curve is
|
|
# tonal and the per-channel curves are chromatic. Filing it under one
|
|
# would hide it from half the people looking for it.
|
|
attributes: [tone, colour]
|
|
rust: ToneCurve
|
|
|
|
why_rust: |
|
|
Five control points presented as one curve widget, with an interpolator and
|
|
a monotonicity guarantee behind it. Its neutral is a *relationship* between
|
|
parameters rather than a set of values — the identity diagonal — which is
|
|
not something the declarative `active:` rule can express, and its
|
|
`presentation()` spans parameters rather than describing one.
|
|
|
|
placement: |
|
|
After the fixed-weight region controls, so the curve is the final word on
|
|
tone: a photographer reaches for it to fix what those controls could not
|
|
place exactly.
|