dtourolleandClaude Opus 5
e235e99cce
An earlier commit claimed to move `film_sim` from `[tone, colour]` to `[effect]` and did not. It edited `ops/film_sim.yaml`, where `attributes:` is read, validated against the vocabulary, and then dropped: a `rust:` node publishes its own descriptor, and the type still said tone and colour. The stock went on appearing in the Light group beside exposure and again in Colour beside white balance, exactly as before, and every test passed. Nothing caught it because nothing could. The declaration parsed, the parity tests compare ids rather than attributes, and an operation filed under the wrong groups renders perfectly. It surfaced only on screen, as a missing Effects tab — which is indistinguishable from a category that genuinely has nothing in it, and is precisely how `Optics` looked for as long as it was empty. So three changes rather than one: `FilmSim`'s descriptor declares `Attribute::Effect`, which is the move the earlier commit described. `attributes:` joins the keys a `rust:` node may not carry, beside `params`, `uniforms`, `wgsl`, `helpers`, `define` and `label`. The rule was already written — "its descriptor comes from the type" — and attributes were the one field that slipped past it. A key that is silently ignored is worse than one that is rejected, because it reads as though it worked; the eight hand-written declarations lose a line that never did anything. And a test asserts that every attribute the chain carries reaches the tab strip. That is the property that was actually broken, and its failure mode is invisible from every direction: the controls exist, they are in the shader, and there is no way to filter to them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
15 lines
527 B
YAML
15 lines
527 B
YAML
id: colour_mixer
|
|
order: 100
|
|
rust: ColourMixer
|
|
|
|
why_rust: |
|
|
Thirty-six parameters — twelve hue bands times hue, saturation and
|
|
luminance — generated as a grid, each carrying a `Facet` naming its band and
|
|
the band's centre on the hue wheel. Spelling that out as thirty-six YAML
|
|
entries would be a worse description than the loop that produces it, and the
|
|
band centres are computed rather than listed.
|
|
|
|
placement: |
|
|
Last. It is the finishing control, and it should act on the tones the user
|
|
has already settled.
|