dtourolle
cb7b9d71c4
run() was 2,724 lines that built every controller, owned the develop session and its render loop, and registered every develop-screen callback inline — the state CH-1 in docs/dev/code-health.md describes. This is the mechanical split CH-1 calls for, done in one pass rather than section by section since develop_ui.rs only compiles once lib.rs stops registering those callbacks itself. develop_ui.rs is new: a DevelopWiring struct holding the session, the rows model, the redraw/render closures and the other controllers' handles, and one wire_* function per section run() used to contain — presets, export, the adjustment panel, film, undo/redo, zoom/pan/crop, rotation/flips/ straightening, navigation and peaking — called in the order run() registered them. window travels as its own parameter throughout rather than living on the struct, because the generated AppWindow type is not Clone; every other field is an owned clone so each function's body could be pasted from run() unchanged. lib.rs::run is now under 300 lines: construction and startup only, calling named functions for the window and its diagnostics/inference wiring, the launch/library/collections/identity/settings screens, import and merge, the render loop (render_now/redraw/show), the remote open path, the window chrome (resize, layout class, panel toggles, back gesture), and develop_ui::wire for the rest. Every TRACES and GESTURE comment moved with the code it annotates. Two latent type errors surfaced while restructuring rather than being introduced by it: activity and display were being passed around as bare ActivityLog/DisplayWatch instead of the Rc<...> their constructors actually return, which only worked before because nothing needed to name the type explicitly.
Documentation
Two audiences, two folders. Most people want the first table and never the second.
Using DarkRoom
| The manual | Every feature, pictured from the application itself — opening a library, rating and filing, developing, local masks, repair, film, panoramas, export |
| How it is driven | Every gesture and shortcut, by screen. Generated from the code, so it cannot describe one the application does not have |
The top-level README says what DarkRoom is, how to get it on each platform, and what is still missing.
Changing DarkRoom
Everything under dev/ is for someone working on the code. Start with
CONTRIBUTING.md, which says how to land a first change
without reading the rest.
The register and the record. What must be built, how it is built, and how far along it is.
| requirements.md | What the software must do — the numbered register, the decisions (D-numbers) and the spikes (S-numbers) |
| architecture.md | How it is built — crates, the GPU pipeline, the data model, sync |
| traceability.md | Generated: which requirement is claimed by which file. Never edited by hand |
| outstanding.md | What is specified and not built, and whether that is a decision or a gap |
| technical-debt.md | Compromises taken deliberately, each with the condition that retires it |
| code-health.md | What a contribution costs, per seam, measured |
Designs, one per subsystem. Each is the specification the code was built to, kept current as the code moved.
| catalog.md | The index, the library view, incremental scan, the job queue |
| storage.md | Storage backends: the seam a folder, a sync client and a Nextcloud account share |
| faces.md | Face detection, identity, clustering and the eye-state models |
| segmentation.md | How the application finds the regions a local mask snaps to |
| mask-editing.md | Painting, erasing and combining masks |
| spot-removal.md | Clone and heal as parameters in the edit graph |
| panorama.md | Alignment, projection, the chunked composite and the border fill |
| inference.md | The neural runtime and model chosen per device, with the measurements |
| display-and-extension.md | The display contract, and why the fused pipeline is already most of a plugin format |
| view-composition.md | A controller for the display layer |
| ui-navigation.md | Finding things in the interface once there are many |
Measurements. Numbers committed so a regression is a diff rather than a recollection.
| benchmarks.md | The per-commit suite: what it covers, what it does not, how to read a failure |
| bench-baseline.json | The committed numbers the suite checks against |
| frame-budget.md | What a frame costs on each device, and the decision those figures settled |
Platforms and distribution.
| distribution.md | Which channels v1 targets and what each one constrains |
| windows.md | The Windows installer, cross-built from the Linux CI |
| android-signing.md | Which key signs the APK, and keeping it |
Archive. Kept as the record of what was asked for, not as plans.
| milestone-v0.1.md | The first milestone, delivered 2026-08-30 and superseded |
| ui-refinement.md | How the interface should look; succeeded by ui-navigation.md |
Conventions
Two files here are generated and must not be edited by hand:
gestures.md and dev/traceability.md. Both come from
cargo run -p traceability and the pre-commit hook keeps them in step with
the tree. The manual's pictures are recorded by
tools/manual and live in LFS.
A design document links to the requirements it satisfies and to the code
that satisfies them. When the code moves, the link moves with it; a document
that has stopped being true goes to dev/archive/ with a note saying what
replaced it, rather than being deleted.