feat: opt-in lossless (blocking) output for nodes and fanouts
Channels drop on overflow by default. That is the right behaviour for live
sources, where a stale item is worth less than a fresh one, but it makes the
library unusable for offline batch work: items vanish with no diagnostic, and
any downstream analysis that assumes a fixed sample rate is silently invalid.
Auto-inserted fanouts were the harder half of this. They are created inside
make_network(), so user code cannot reach them to configure, and they drop
per-output inside a swallowed catch — so a pipeline whose own nodes were all
configured lossless could still lose items with nothing reported anywhere. In
the pipeline this came from, capture's 2505 frames arrived at the detector as
774 while the overflow counter read zero.
Adds:
- INode::set_lossless_output(bool), defaulted to a no-op so node types with
no output channels ignore it
- PoolNode / PoolObjectNode: route push_one_out() through push_blocking()
- FanoutNode: same, plus set_lossy_output(i) to opt a single branch back out
- StaticNetwork::set_lossless(), which reaches user nodes and fanouts alike
- StaticNetwork::drain(), a public wrapper over the existing private
drain_all_channels(), so callers can flush in-flight work before stop()
Default behaviour is unchanged; every path is off unless explicitly enabled.
Blocking output is only safe when every consumer eventually drains. A branch
that can stall indefinitely — a display node nobody is servicing — will apply
backpressure to the whole pipeline, which is what set_lossy_output() is for.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
+25
-2
@@ -115,6 +115,16 @@ public:
|
||||
out_channels_[I] = ch;
|
||||
}
|
||||
|
||||
// Lossless fanout: block until each consumer drains rather than dropping.
|
||||
void set_lossless_output(bool on) override { lossless_ = on; }
|
||||
|
||||
// Opt a single output back out of blocking. Needed when one branch may
|
||||
// stall indefinitely — a display tap nobody is servicing, say — since
|
||||
// blocking on it would apply backpressure to every other branch too.
|
||||
void set_lossy_output(std::size_t i, bool lossy = true) {
|
||||
if (i < N) lossy_out_[i] = lossy;
|
||||
}
|
||||
|
||||
private:
|
||||
void run_loop() {
|
||||
while (!stop_flag_.load(std::memory_order_relaxed)) {
|
||||
@@ -126,8 +136,19 @@ private:
|
||||
|
||||
for (std::size_t i = 0; i < N; ++i) {
|
||||
if (out_channels_[i]) {
|
||||
try { out_channels_[i]->push(val); }
|
||||
catch (const ChannelOverflowError&) {} // drop for this output independently
|
||||
// Lossless: block until this consumer drains. Note the
|
||||
// branches differ in more than blocking — the dropping
|
||||
// path discards per-output independently and silently,
|
||||
// so a slow consumer on one branch costs frames on that
|
||||
// branch only, with no diagnostic. That is the right
|
||||
// default for display taps but hides frame loss from
|
||||
// analysis branches.
|
||||
if (lossless_ && !lossy_out_[i])
|
||||
out_channels_[i]->push_blocking(val);
|
||||
else {
|
||||
try { out_channels_[i]->push(val); }
|
||||
catch (const ChannelOverflowError&) {} // drop independently
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -142,6 +163,8 @@ private:
|
||||
|
||||
std::string name_;
|
||||
std::size_t fifo_capacity_;
|
||||
bool lossless_{false};
|
||||
std::array<bool, N> lossy_out_{}; // per-output opt-out of blocking
|
||||
std::shared_ptr<Channel<T>> input_ch_;
|
||||
std::array<Channel<T>*, N> out_channels_{};
|
||||
std::atomic<bool> stop_flag_{false};
|
||||
|
||||
Reference in New Issue
Block a user