dtourolleandClaude Opus 5
bd08629fff
Jellyfin 12 moved to .NET 10 and changed the IUserManager surface the plugin relies on: Users/UsersIds became GetUsers()/GetUsersIds(), ChangePassword takes a user id, HasPassword left the provider contract, and the user cache is gone, so every lookup is a detached copy. The plugin now multi-targets net9.0 (against 10.11.5) and net10.0 (against 12.0.0). The differences sit behind a JELLYFIN_12 constant in Compat/UserManagerCompat.cs, whose ChangePasswordAsync also carries the stored hash back onto the caller's instance: on 12 the UpdateUserAsync that claims the account would otherwise write the stale null password back over the one provisioning just set. Each release ships one package per generation, with the fourth version segment naming the target (x.y.z.11 and x.y.z.12) so a 12 server picks the 12 package over the 10.11 one. scripts/package.sh wraps jprm for a single generation and the workflows call it twice. The builder image moves to the .NET 10 SDK, which builds both targets; the net9.0 test run rolls forward onto the .NET 10 runtime. CA1873 is a .NET 10 analyzer that flags the same log calls CA1848 does; it is set to Info, as in the upstream Jellyfin 12 tree. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
95 lines
3.4 KiB
YAML
95 lines
3.4 KiB
YAML
name: '🏗️ Build Plugin'
|
|
|
|
on:
|
|
push:
|
|
branches:
|
|
- master
|
|
paths-ignore:
|
|
- '**/*.md'
|
|
pull_request:
|
|
branches:
|
|
- master
|
|
paths-ignore:
|
|
- '**/*.md'
|
|
workflow_dispatch:
|
|
|
|
jobs:
|
|
build:
|
|
runs-on: linux/amd64
|
|
container:
|
|
image: gitea.tourolle.paris/dtourolle/watchedtogether-builder:latest
|
|
|
|
steps:
|
|
- name: Checkout repository
|
|
uses: actions/checkout@v4
|
|
with:
|
|
path: build-${{ github.run_id }}
|
|
|
|
- name: Cache NuGet packages
|
|
uses: actions/cache@v3
|
|
with:
|
|
path: ~/.nuget/packages
|
|
key: nuget-${{ hashFiles('**/Jellyfin.Plugin.WatchedTogether.csproj', '**/Jellyfin.Plugin.WatchedTogether.Tests.csproj') }}
|
|
restore-keys: nuget-
|
|
|
|
- name: Restore dependencies
|
|
working-directory: build-${{ github.run_id }}
|
|
run: dotnet restore Jellyfin.Plugin.WatchedTogether.sln
|
|
|
|
- name: Compute build version
|
|
id: version
|
|
run: |
|
|
# Date-based version so a side-loaded build is identifiable in Jellyfin.
|
|
DATE=$(date -u +"%Y%m%d")
|
|
VERSION="1.0.${DATE}.${{ github.run_number }}"
|
|
if [ -n "${{ github.event.pull_request.number }}" ]; then
|
|
LABEL="pr${{ github.event.pull_request.number }}"
|
|
else
|
|
LABEL="master"
|
|
fi
|
|
echo "version=${VERSION}" >> $GITHUB_OUTPUT
|
|
echo "label=${LABEL}" >> $GITHUB_OUTPUT
|
|
echo "Build version: ${VERSION} (${LABEL})"
|
|
|
|
- name: Set build version
|
|
working-directory: build-${{ github.run_id }}
|
|
run: |
|
|
sed -i "s/^version:.*/version: \"${{ steps.version.outputs.version }}\"/" build.yaml
|
|
|
|
- name: Build solution
|
|
working-directory: build-${{ github.run_id }}
|
|
run: dotnet build Jellyfin.Plugin.WatchedTogether.sln --configuration Release --no-restore --no-self-contained /m:1
|
|
|
|
- name: Run tests
|
|
working-directory: build-${{ github.run_id }}
|
|
run: dotnet test Jellyfin.Plugin.WatchedTogether.sln --no-build --configuration Release --verbosity normal
|
|
|
|
- name: Package for Jellyfin 10.11 and 12
|
|
working-directory: build-${{ github.run_id }}
|
|
run: |
|
|
# One package per Jellyfin generation. Both carry the same date-based version, so they
|
|
# go to separate directories; the meta.json targetAbi inside each tells them apart.
|
|
scripts/package.sh 10.11 "${{ steps.version.outputs.version }}" artifacts/jellyfin-10.11
|
|
scripts/package.sh 12 "${{ steps.version.outputs.version }}" artifacts/jellyfin-12
|
|
find artifacts -name "*.zip" -type f
|
|
|
|
- name: Upload Jellyfin 10.11 package
|
|
uses: actions/upload-artifact@v3
|
|
with:
|
|
name: watchedtogether-${{ steps.version.outputs.label }}-${{ steps.version.outputs.version }}-jellyfin-10.11
|
|
path: build-${{ github.run_id }}/artifacts/jellyfin-10.11/*.zip
|
|
retention-days: 30
|
|
if-no-files-found: error
|
|
|
|
- name: Upload Jellyfin 12 package
|
|
uses: actions/upload-artifact@v3
|
|
with:
|
|
name: watchedtogether-${{ steps.version.outputs.label }}-${{ steps.version.outputs.version }}-jellyfin-12
|
|
path: build-${{ github.run_id }}/artifacts/jellyfin-12/*.zip
|
|
retention-days: 30
|
|
if-no-files-found: error
|
|
|
|
- name: Cleanup
|
|
if: always()
|
|
run: rm -rf build-${{ github.run_id }}
|