JR-021, JR-022, JR-023: File Transformation is a hard dependency
Deletes the on-disk index.html injection rather than leaving it switched off. Plugin.cs had already stopped calling it, but an unreachable write path with a live signature is the one a later refactor re-enables by accident, and it was still the behaviour the README and the release changelog advertised. Patching index.html on disk is destructive in ways a plugin cannot clean up after: the patch outlives an uninstall, a web-client upgrade discards it silently, and it races any other plugin touching the same file. It is also a second code path, and the one nobody runs is the one that rots. WebClientPatchService is now removal-only. The strip is factored out as RemoveInjection so it is testable without a filesystem. Removal is the one write JR-021 permits -- an earlier JRay did patch the file, and those users must not be left with a stale injection pointing at endpoints that have since changed. It keys on JRay's own marker, so it touches nothing another plugin added. JR-021 is a requirement to *not do* something, which no unit test can demonstrate, so scripts/checks/no-index-injection.sh verifies it by absence. The check was confirmed to fail on a reintroduced Apply() and on reintroduced ReplaceLast injection -- a check that has only ever passed is not evidence. Jellyfin has no plugin dependency mechanism, so nothing installs File Transformation for the user and a log warning alone is one nobody reads. GET /Plugins/JRay/Status/Dependencies reports whether the dependency is satisfied, and the configuration page renders it with the repository URL and what to do with it. Absent the plugin only the overlay is disabled; every other feature works. JR-022 and JR-023 stay In Progress rather than Done: neither has a test that executes, and this repo has no test project yet. TRACES: JR-021, JR-022, JR-023 | PR-004 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,37 @@
|
||||
using System.Text.Json.Serialization;
|
||||
|
||||
namespace Jellyfin.Plugin.JRay.Models;
|
||||
|
||||
/// <summary>
|
||||
/// Whether JRay's one hard dependency is satisfied, and what to do if it is not.
|
||||
/// </summary>
|
||||
/// <remarks>
|
||||
/// Jellyfin has no plugin dependency mechanism — a manifest cannot declare that
|
||||
/// another plugin is required, and nothing will install one. The gap is closed by
|
||||
/// telling the admin, on the page where they can act on it. A warning that exists
|
||||
/// only in the server log is one nobody reads.
|
||||
/// </remarks>
|
||||
public class DependencyStatus
|
||||
{
|
||||
/// <summary>
|
||||
/// Gets or sets a value indicating whether the File Transformation plugin was
|
||||
/// found and JRay's overlay transformation registered with it.
|
||||
/// </summary>
|
||||
[JsonPropertyName("file_transformation_available")]
|
||||
public bool FileTransformationAvailable { get; set; }
|
||||
|
||||
/// <summary>
|
||||
/// Gets or sets a value indicating whether the overlay is switched on in
|
||||
/// configuration. It is served only when this <i>and</i>
|
||||
/// <see cref="FileTransformationAvailable"/> hold.
|
||||
/// </summary>
|
||||
[JsonPropertyName("overlay_enabled")]
|
||||
public bool OverlayEnabled { get; set; }
|
||||
|
||||
/// <summary>
|
||||
/// Gets or sets the repository manifest URL an admin adds to install the
|
||||
/// missing dependency.
|
||||
/// </summary>
|
||||
[JsonPropertyName("file_transformation_manifest_url")]
|
||||
public string FileTransformationManifestUrl { get; set; } = string.Empty;
|
||||
}
|
||||
Reference in New Issue
Block a user