dtourolleandClaude Opus 5
d9a38bb7fb
Deletes the on-disk index.html injection rather than leaving it switched off. Plugin.cs had already stopped calling it, but an unreachable write path with a live signature is the one a later refactor re-enables by accident, and it was still the behaviour the README and the release changelog advertised. Patching index.html on disk is destructive in ways a plugin cannot clean up after: the patch outlives an uninstall, a web-client upgrade discards it silently, and it races any other plugin touching the same file. It is also a second code path, and the one nobody runs is the one that rots. WebClientPatchService is now removal-only. The strip is factored out as RemoveInjection so it is testable without a filesystem. Removal is the one write JR-021 permits -- an earlier JRay did patch the file, and those users must not be left with a stale injection pointing at endpoints that have since changed. It keys on JRay's own marker, so it touches nothing another plugin added. JR-021 is a requirement to *not do* something, which no unit test can demonstrate, so scripts/checks/no-index-injection.sh verifies it by absence. The check was confirmed to fail on a reintroduced Apply() and on reintroduced ReplaceLast injection -- a check that has only ever passed is not evidence. Jellyfin has no plugin dependency mechanism, so nothing installs File Transformation for the user and a log warning alone is one nobody reads. GET /Plugins/JRay/Status/Dependencies reports whether the dependency is satisfied, and the configuration page renders it with the repository URL and what to do with it. Absent the plugin only the overlay is disabled; every other feature works. JR-022 and JR-023 stay In Progress rather than Done: neither has a test that executes, and this repo has no test project yet. TRACES: JR-021, JR-022, JR-023 | PR-004 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
28 lines
1.1 KiB
YAML
28 lines
1.1 KiB
YAML
---
|
|
name: "JRay"
|
|
guid: "96a22d9d-23fd-49bb-8970-5e153817d223"
|
|
version: "0.0.0.0"
|
|
targetAbi: "10.9.0.0"
|
|
framework: "net9.0"
|
|
overview: "Shows which actors are on screen at any point in a movie"
|
|
description: >
|
|
JRay reads "truth" files produced offline by the scene-actor-extraction
|
|
pipeline (face detection + recognition) and exposes an API to query which
|
|
actors are visible on screen at a given timestamp in a movie, for building
|
|
an actor-overlay (Jellyfin "X-Ray") style feature.
|
|
category: "General"
|
|
owner: "dtourolle"
|
|
artifacts:
|
|
- "Jellyfin.Plugin.JRay.dll"
|
|
build_type: "dotnet"
|
|
dotnet_configuration: "Release"
|
|
dotnet_framework: "net9.0"
|
|
project: "Jellyfin.Plugin.JRay/Jellyfin.Plugin.JRay.csproj"
|
|
changelog: >
|
|
The pause overlay is now served through the File Transformation plugin, which
|
|
rewrites the web client's index.html as it is sent. JRay no longer edits that
|
|
file on disk and there is no fallback: without File Transformation the overlay
|
|
is disabled and every other feature works normally. Any stale on-disk patch
|
|
left by an earlier JRay is removed on startup, and the plugin's configuration
|
|
page now reports whether the dependency is satisfied.
|