feat(offline): play downloaded video, and drain the offline sync queue (0.4.6)
🏗️ Build and Test JellyTau / Run Tests (push) Successful in 20m34s
Publish Documentation / Build & publish docs to gitea-pages (push) Successful in 6m6s
Traceability Validation / Check Requirement Traces (push) Successful in 18s
Build & Release / Run Tests (push) Successful in 20m26s
🏗️ Build and Test JellyTau / Android Compile Check (push) Successful in 10m3s
Build & Release / Build Linux (push) Successful in 37m59s
Build & Release / Build Windows (push) Successful in 23m0s
Build & Release / Build Android (push) Successful in 40m26s
Build & Release / Create Release (push) Successful in 1m20s

Bundles this session's work plus the concurrent search/offline/player changes.
Every gate passes on the combined tree: 885 frontend tests, 610 Rust tests,
clippy clean, boundary clean, trace coverage 86%.

Offline video playback — four separate defects, each of which alone stopped it:

  DR-133  A completed download's file_path is already absolute (the worker
          rewrites it on completion), but the player rooted it a second time and
          handed the webview /data/user/0/app//data/user/0/app/videos/x.mp4.
  DR-134  The asset protocol was never enabled: no protocol-asset feature and no
          assetProtocol config, so convertFileSrc produced URLs nothing answered.
          Also silently defeated the cached-thumbnail path, which fails soft to
          the server copy and hid it whenever the server was reachable.
  DR-137  Tauri's asset protocol answers a range-less request by reading the
          whole file into memory, and only advertises Accept-Ranges from inside
          its range branch, so the first request never learns ranges exist.
          Chromium gave up with PIPELINE_ERROR_READ after ~31s. Local media is
          now served by a loopback HTTP server: bounded 4 MiB chunks streamed
          from the file handle, every response length-delimited, and a range-less
          request answered with one chunk rather than the file. Confined by a
          per-session token and to the app data directory, because loopback is
          shared between apps on Android.
  DR-138  Release builds set usesCleartextTraffic=false, so Android rejected the
          request to that server before any I/O. A network-security-config
          exempts 127.0.0.1 only; a remote server must still be HTTPS.

Downloads:

  DR-135  download_item never records media_type and the reconnect resolver read
          that NULL as 'audio', so a movie queued from a media card had its URL
          resolved by get_audio_stream_url and completed as an audio-only
          transcode. The item's own type now decides.
  DR-136  Rows already downloaded that way are requeued on reconnect, since
          prevention alone leaves them reading "downloaded" and still unplayable.

Known limitation: a download taken at `original` quality is a byte copy of the
source, so it can be any container. One such file is an AVI holding XVID, which
the webview cannot play in any case — the media server serves it correctly and
Chromium refuses it. That needs either a transcoded download preset or the
native ExoPlayer surface work, and is not addressed here.

Also fixes two ID collisions between concurrent work: DR-143 defined twice
(search vs offline gate) and UT-131 defined twice (Episode Focus hero vs channel
cap). The search requirement is now DR-147 and the channel-cap test UT-141, with
their code references and matrix rows updated.
This commit is contained in:
2026-08-09 16:38:07 +02:00
parent 7b531a40be
commit 1b70926c36
58 changed files with 8130 additions and 2347 deletions
@@ -0,0 +1,55 @@
// TRACES: UR-052 | DR-143 | UT-140
import { describe, it, expect, vi, beforeEach } from "vitest";
import { writable } from "svelte/store";
const h = vi.hoisted(() => ({
version: null as ReturnType<typeof import("svelte/store").writable<number>> | null,
destroyFns: [] as Array<() => void>,
}));
vi.mock("svelte", () => ({
onDestroy: (fn: () => void) => h.destroyFns.push(fn),
}));
vi.mock("$lib/services/offlineCatalog", () => ({
get catalogFilterVersion() {
return h.version;
},
}));
import { useOfflineFilterReload } from "./useOfflineFilterReload";
describe("useOfflineFilterReload (DR-143)", () => {
beforeEach(() => {
h.version = writable(0);
h.destroyFns.length = 0;
});
it("does not reload for the value the page already loaded under", () => {
const reload = vi.fn();
useOfflineFilterReload(reload);
expect(reload).not.toHaveBeenCalled();
});
it("reloads once each time the gate settles into a new state", () => {
const reload = vi.fn();
useOfflineFilterReload(reload);
h.version!.set(1);
expect(reload).toHaveBeenCalledTimes(1);
h.version!.set(2);
expect(reload).toHaveBeenCalledTimes(2);
});
it("stops reloading a page that has been destroyed", () => {
const reload = vi.fn();
useOfflineFilterReload(reload);
h.destroyFns.forEach((fn) => fn());
h.version!.set(1);
expect(reload).not.toHaveBeenCalled();
});
});
@@ -0,0 +1,47 @@
/**
* Re-query a listing when the offline "downloaded only" gate changes.
*
* The gate is a process-wide flag in Rust, consulted only while a query runs,
* so flipping it has no effect on rows already on screen. Library pages loaded
* once on mount and reloaded only on the offline → online transition
* (`useServerReachabilityReload`), which left two gaps the user sees as a broken
* filter:
*
* - going *offline* never reloaded, so the full server catalog stayed on
* screen under a now-closed gate;
* - toggling "Show all server media" never reloaded, so it only greyed the
* cards already listed instead of adding or removing any.
*
* `catalogFilterVersion` bumps once the backend has accepted the new gate, so
* the reload this triggers always queries under the intended filter.
*
* Call during component initialisation, like `useServerReachabilityReload`:
*
* ```svelte
* <script>
* useOfflineFilterReload(() => loadItems());
* </script>
* ```
*
* TRACES: UR-052 | DR-143
*/
import { onDestroy } from "svelte";
import { catalogFilterVersion } from "$lib/services/offlineCatalog";
export function useOfflineFilterReload(reloadFn: () => void | Promise<void>): void {
// The value the page is already showing. Seeded from the first subscription
// callback (stores emit synchronously on subscribe) so mounting never
// triggers a redundant second load of what onMount just fetched.
let applied: number | null = null;
const unsubscribe = catalogFilterVersion.subscribe((version) => {
if (applied === null || version === applied) {
applied = version;
return;
}
applied = version;
void reloadFn();
});
onDestroy(unsubscribe);
}