feat(offline): play downloaded video, and drain the offline sync queue (0.4.6)
🏗️ Build and Test JellyTau / Run Tests (push) Successful in 20m34s
Publish Documentation / Build & publish docs to gitea-pages (push) Successful in 6m6s
Traceability Validation / Check Requirement Traces (push) Successful in 18s
Build & Release / Run Tests (push) Successful in 20m26s
🏗️ Build and Test JellyTau / Android Compile Check (push) Successful in 10m3s
Build & Release / Build Linux (push) Successful in 37m59s
Build & Release / Build Windows (push) Successful in 23m0s
Build & Release / Build Android (push) Successful in 40m26s
Build & Release / Create Release (push) Successful in 1m20s

Bundles this session's work plus the concurrent search/offline/player changes.
Every gate passes on the combined tree: 885 frontend tests, 610 Rust tests,
clippy clean, boundary clean, trace coverage 86%.

Offline video playback — four separate defects, each of which alone stopped it:

  DR-133  A completed download's file_path is already absolute (the worker
          rewrites it on completion), but the player rooted it a second time and
          handed the webview /data/user/0/app//data/user/0/app/videos/x.mp4.
  DR-134  The asset protocol was never enabled: no protocol-asset feature and no
          assetProtocol config, so convertFileSrc produced URLs nothing answered.
          Also silently defeated the cached-thumbnail path, which fails soft to
          the server copy and hid it whenever the server was reachable.
  DR-137  Tauri's asset protocol answers a range-less request by reading the
          whole file into memory, and only advertises Accept-Ranges from inside
          its range branch, so the first request never learns ranges exist.
          Chromium gave up with PIPELINE_ERROR_READ after ~31s. Local media is
          now served by a loopback HTTP server: bounded 4 MiB chunks streamed
          from the file handle, every response length-delimited, and a range-less
          request answered with one chunk rather than the file. Confined by a
          per-session token and to the app data directory, because loopback is
          shared between apps on Android.
  DR-138  Release builds set usesCleartextTraffic=false, so Android rejected the
          request to that server before any I/O. A network-security-config
          exempts 127.0.0.1 only; a remote server must still be HTTPS.

Downloads:

  DR-135  download_item never records media_type and the reconnect resolver read
          that NULL as 'audio', so a movie queued from a media card had its URL
          resolved by get_audio_stream_url and completed as an audio-only
          transcode. The item's own type now decides.
  DR-136  Rows already downloaded that way are requeued on reconnect, since
          prevention alone leaves them reading "downloaded" and still unplayable.

Known limitation: a download taken at `original` quality is a byte copy of the
source, so it can be any container. One such file is an AVI holding XVID, which
the webview cannot play in any case — the media server serves it correctly and
Chromium refuses it. That needs either a transcoded download preset or the
native ExoPlayer surface work, and is not addressed here.

Also fixes two ID collisions between concurrent work: DR-143 defined twice
(search vs offline gate) and UT-131 defined twice (Episode Focus hero vs channel
cap). The search requirement is now DR-147 and the channel-cap test UT-141, with
their code references and matrix rows updated.
This commit is contained in:
2026-08-09 16:38:07 +02:00
parent 7b531a40be
commit 1b70926c36
58 changed files with 8130 additions and 2347 deletions
@@ -0,0 +1,162 @@
// The offline "downloaded only" gate is a *backend* flag, so flipping it only
// changes what the user sees if the listing is re-queried afterwards. Nothing
// re-queried: the toggle greyed cards instantly (a pure frontend derivation in
// MediaCard) while the item list stayed exactly as it was loaded, which is why
// the filter read as "shows everything until I toggle, then greys some of it".
//
// `catalogFilterVersion` is the refetch signal, and it must bump only once the
// backend has actually accepted the new flag — a reload racing the push would
// re-query under the old gate and land back where it started.
//
// TRACES: UR-052 | DR-078, DR-143 | UT-137, UT-138, UT-139
import { describe, it, expect, vi, beforeEach } from "vitest";
import { get } from "svelte/store";
const h = vi.hoisted(() => {
function shim<T>(initial: T) {
let value = initial;
const subs = new Set<(v: T) => void>();
return {
set(v: T) {
value = v;
subs.forEach((fn) => fn(value));
},
subscribe(fn: (v: T) => void) {
subs.add(fn);
fn(value);
return () => subs.delete(fn);
},
/**
* Drop subscribers from previously imported copies of the module.
* `vi.resetModules()` gives each test a fresh module instance, but this
* store outlives them all — without this the stale instances keep
* consuming `mockImplementationOnce` and pushing their own state.
*/
reset(v: T) {
subs.clear();
value = v;
},
};
}
return {
isConnectedStore: shim(true),
// Resolution is deferred so a test can observe the window between "command
// issued" and "command accepted".
pending: [] as Array<() => void>,
setShowServerCatalog: vi.fn(
() => new Promise<void>((resolve) => h.pending.push(() => resolve()))
),
};
});
vi.mock("$lib/stores/connectivity", () => ({
isConnected: { subscribe: h.isConnectedStore.subscribe },
}));
vi.mock("$lib/api/bindings", () => ({
commands: {
setShowServerCatalog: h.setShowServerCatalog,
syncFullCatalog: vi.fn(),
resumeQueuedDownloads: vi.fn(),
catalogSyncStatus: vi.fn(),
},
}));
vi.mock("$lib/stores/auth", () => ({
auth: { getRepository: () => ({ getHandle: () => "handle-1" }) },
}));
/** Let every issued setShowServerCatalog settle. */
async function settle() {
h.pending.splice(0).forEach((resolve) => resolve());
await Promise.resolve();
await Promise.resolve();
}
describe("offline filter refetch signal (DR-143)", () => {
beforeEach(() => {
h.setShowServerCatalog.mockReset();
h.setShowServerCatalog.mockImplementation(
() => new Promise<void>((resolve) => h.pending.push(() => resolve()))
);
h.pending.length = 0;
h.isConnectedStore.reset(true);
vi.resetModules();
});
it("bumps the version when going offline closes the gate", async () => {
const mod = await import("./offlineCatalog");
await settle();
const before = get(mod.catalogFilterVersion);
h.isConnectedStore.set(false); // include: true → false
await settle();
expect(h.setShowServerCatalog).toHaveBeenLastCalledWith(false);
expect(get(mod.catalogFilterVersion)).toBeGreaterThan(before);
});
it("bumps only after the backend accepts the flag, never before", async () => {
const mod = await import("./offlineCatalog");
await settle();
const before = get(mod.catalogFilterVersion);
h.isConnectedStore.set(false);
await Promise.resolve(); // command issued, not yet resolved
expect(h.setShowServerCatalog).toHaveBeenLastCalledWith(false);
expect(get(mod.catalogFilterVersion)).toBe(before);
await settle();
expect(get(mod.catalogFilterVersion)).toBeGreaterThan(before);
});
it("bumps both ways as the offline toggle is flipped", async () => {
const mod = await import("./offlineCatalog");
h.isConnectedStore.set(false);
await settle();
const offlineGated = get(mod.catalogFilterVersion);
mod.showServerCatalog.set(true); // reveal the server catalog
await settle();
expect(h.setShowServerCatalog).toHaveBeenLastCalledWith(true);
const revealed = get(mod.catalogFilterVersion);
expect(revealed).toBeGreaterThan(offlineGated);
mod.showServerCatalog.set(false); // back to downloaded-only
await settle();
expect(h.setShowServerCatalog).toHaveBeenLastCalledWith(false);
expect(get(mod.catalogFilterVersion)).toBeGreaterThan(revealed);
});
it("does not bump when the effective gate is unchanged", async () => {
const mod = await import("./offlineCatalog");
await settle();
const before = get(mod.catalogFilterVersion);
// Online, the toggle cannot close the gate — browsing reads the same cache.
mod.showServerCatalog.set(true);
await settle();
expect(get(mod.catalogFilterVersion)).toBe(before);
});
it("retries the push after a failed one rather than latching the old gate", async () => {
const mod = await import("./offlineCatalog");
await settle();
const before = get(mod.catalogFilterVersion);
h.setShowServerCatalog.mockImplementationOnce(() => Promise.reject(new Error("ipc down")));
h.isConnectedStore.set(false);
await settle();
expect(get(mod.catalogFilterVersion)).toBe(before); // nothing to reload for
// The same transition must be attempted again, not skipped as "already sent".
h.isConnectedStore.set(true);
await settle();
h.isConnectedStore.set(false);
await settle();
expect(h.setShowServerCatalog).toHaveBeenLastCalledWith(false);
expect(get(mod.catalogFilterVersion)).toBeGreaterThan(before);
});
});