feat(offline): play downloaded video, and drain the offline sync queue (0.4.6)
🏗️ Build and Test JellyTau / Run Tests (push) Successful in 20m34s
Publish Documentation / Build & publish docs to gitea-pages (push) Successful in 6m6s
Traceability Validation / Check Requirement Traces (push) Successful in 18s
Build & Release / Run Tests (push) Successful in 20m26s
🏗️ Build and Test JellyTau / Android Compile Check (push) Successful in 10m3s
Build & Release / Build Linux (push) Successful in 37m59s
Build & Release / Build Windows (push) Successful in 23m0s
Build & Release / Build Android (push) Successful in 40m26s
Build & Release / Create Release (push) Successful in 1m20s

Bundles this session's work plus the concurrent search/offline/player changes.
Every gate passes on the combined tree: 885 frontend tests, 610 Rust tests,
clippy clean, boundary clean, trace coverage 86%.

Offline video playback — four separate defects, each of which alone stopped it:

  DR-133  A completed download's file_path is already absolute (the worker
          rewrites it on completion), but the player rooted it a second time and
          handed the webview /data/user/0/app//data/user/0/app/videos/x.mp4.
  DR-134  The asset protocol was never enabled: no protocol-asset feature and no
          assetProtocol config, so convertFileSrc produced URLs nothing answered.
          Also silently defeated the cached-thumbnail path, which fails soft to
          the server copy and hid it whenever the server was reachable.
  DR-137  Tauri's asset protocol answers a range-less request by reading the
          whole file into memory, and only advertises Accept-Ranges from inside
          its range branch, so the first request never learns ranges exist.
          Chromium gave up with PIPELINE_ERROR_READ after ~31s. Local media is
          now served by a loopback HTTP server: bounded 4 MiB chunks streamed
          from the file handle, every response length-delimited, and a range-less
          request answered with one chunk rather than the file. Confined by a
          per-session token and to the app data directory, because loopback is
          shared between apps on Android.
  DR-138  Release builds set usesCleartextTraffic=false, so Android rejected the
          request to that server before any I/O. A network-security-config
          exempts 127.0.0.1 only; a remote server must still be HTTPS.

Downloads:

  DR-135  download_item never records media_type and the reconnect resolver read
          that NULL as 'audio', so a movie queued from a media card had its URL
          resolved by get_audio_stream_url and completed as an audio-only
          transcode. The item's own type now decides.
  DR-136  Rows already downloaded that way are requeued on reconnect, since
          prevention alone leaves them reading "downloaded" and still unplayable.

Known limitation: a download taken at `original` quality is a byte copy of the
source, so it can be any container. One such file is an AVI holding XVID, which
the webview cannot play in any case — the media server serves it correctly and
Chromium refuses it. That needs either a transcoded download preset or the
native ExoPlayer surface work, and is not addressed here.

Also fixes two ID collisions between concurrent work: DR-143 defined twice
(search vs offline gate) and UT-131 defined twice (Episode Focus hero vs channel
cap). The search requirement is now DR-147 and the channel-cap test UT-141, with
their code references and matrix rows updated.
This commit is contained in:
2026-08-09 16:38:07 +02:00
parent 7b531a40be
commit 1b70926c36
58 changed files with 8130 additions and 2347 deletions
@@ -0,0 +1,85 @@
// TRACES: UR-025 | DR-132 | UT-123
import { describe, it, expect } from "vitest";
import type { SyncQueueItem } from "$lib/api/bindings";
import {
describeOperation,
describeSubject,
isStuck,
summarize,
sortForDisplay,
} from "./pendingSync.logic";
function row(overrides: Partial<SyncQueueItem> = {}): SyncQueueItem {
return {
id: 1,
userId: "u1",
operation: "report_playback_stopped",
itemId: "ep1",
payload: null,
status: "pending",
retryCount: 0,
createdAt: "2026-08-01T10:00:00Z",
errorMessage: null,
itemName: null,
...overrides,
} as SyncQueueItem;
}
describe("pending sync row description", () => {
it("labels the operations the backend can queue", () => {
expect(describeOperation("report_playback_stopped")).toBe("Watch position");
expect(describeOperation("mark_played")).toBe("Marked as watched");
expect(describeOperation("report_playback_start")).toBe("Playback started");
});
it("still renders an operation it has no label for", () => {
// An unlabelled row is the one heading for abandonment — it must not
// render blank, which is the failure this whole surface exists to fix.
expect(describeOperation("teleport_item")).toBe("teleport item");
});
it("names the item when the catalog knows it, and falls back to the id", () => {
expect(describeSubject(row({ itemName: "The Expanse S01E01" }))).toBe(
"The Expanse S01E01",
);
expect(describeSubject(row({ itemName: null, itemId: "abc123" }))).toBe("abc123");
expect(describeSubject(row({ itemName: null, itemId: null }))).toBe("Unknown item");
});
});
describe("stuck rows", () => {
it("treats a failed or retried row as stuck", () => {
expect(isStuck(row({ status: "failed", retryCount: 1 }))).toBe(true);
expect(isStuck(row({ status: "pending", retryCount: 2 }))).toBe(true);
expect(isStuck(row())).toBe(false);
});
it("summarizes a mixed queue", () => {
const summary = summarize([row(), row({ id: 2, status: "failed", retryCount: 1 })]);
expect(summary).toEqual({ total: 2, stuck: 1, allStuck: false });
});
it("reports allStuck only when every row has failed", () => {
expect(summarize([row({ status: "failed", retryCount: 3 })]).allStuck).toBe(true);
expect(summarize([]).allStuck).toBe(false);
});
});
describe("display order", () => {
it("lists oldest first — the order they will be replayed in", () => {
const sorted = sortForDisplay([
row({ id: 3, createdAt: "2026-08-01T12:00:00Z" }),
row({ id: 1, createdAt: "2026-08-01T10:00:00Z" }),
row({ id: 2, createdAt: "2026-08-01T11:00:00Z" }),
]);
expect(sorted.map((r) => r.id)).toEqual([1, 2, 3]);
});
it("keeps timestamp-less rows instead of dropping them", () => {
const sorted = sortForDisplay([
row({ id: 2, createdAt: null }),
row({ id: 1, createdAt: "2026-08-01T10:00:00Z" }),
]);
expect(sorted.map((r) => r.id)).toEqual([1, 2]);
});
});