Layout and search fix
🏗️ Build and Test JellyTau / Run Tests (push) Failing after 2m4s
🏗️ Build and Test JellyTau / Android Compile Check (push) Has been skipped
Traceability Validation / Check Requirement Traces (push) Successful in 23s
Build & Release / Run Tests (push) Failing after 2m45s
Build & Release / Build Linux (push) Has been skipped
Build & Release / Build Android (push) Has been skipped
Build & Release / Create Release (push) Has been skipped
🏗️ Build and Test JellyTau / Run Tests (push) Failing after 2m4s
🏗️ Build and Test JellyTau / Android Compile Check (push) Has been skipped
Traceability Validation / Check Requirement Traces (push) Successful in 23s
Build & Release / Run Tests (push) Failing after 2m45s
Build & Release / Build Linux (push) Has been skipped
Build & Release / Build Android (push) Has been skipped
Build & Release / Create Release (push) Has been skipped
This commit is contained in:
@@ -295,6 +295,68 @@ describe("playbackMode store", () => {
|
||||
});
|
||||
});
|
||||
|
||||
describe("refresh (reconcile to Rust authoritative mode)", () => {
|
||||
it("adopts the Rust mode and aligns the selected session", async () => {
|
||||
const { playbackMode } = await import("./playbackMode");
|
||||
|
||||
// Start disagreeing with Rust: store thinks local, Rust says remote.
|
||||
playbackMode.setMode("local");
|
||||
mockInvoke.mockResolvedValueOnce({ type: "remote", session_id: "sess-xyz" });
|
||||
|
||||
await playbackMode.refresh();
|
||||
|
||||
const state = get(playbackMode);
|
||||
expect(state.mode).toBe("remote");
|
||||
expect(state.remoteSessionId).toBe("sess-xyz");
|
||||
// The merged UI stores follow selectedSession, so it must be aligned too.
|
||||
expect(mockSelectSession).toHaveBeenCalledWith("sess-xyz");
|
||||
});
|
||||
|
||||
it("clears the selected session when Rust reports non-remote", async () => {
|
||||
const { playbackMode } = await import("./playbackMode");
|
||||
|
||||
playbackMode.setMode("remote", "sess-old");
|
||||
mockInvoke.mockResolvedValueOnce({ type: "idle" });
|
||||
|
||||
await playbackMode.refresh();
|
||||
|
||||
const state = get(playbackMode);
|
||||
expect(state.mode).toBe("idle");
|
||||
expect(state.remoteSessionId).toBeNull();
|
||||
expect(mockSelectSession).toHaveBeenCalledWith(null);
|
||||
});
|
||||
});
|
||||
|
||||
describe("transfer reconciles to Rust on completion", () => {
|
||||
it("refreshes from Rust after a successful transferToRemote", async () => {
|
||||
const { playbackMode } = await import("./playbackMode");
|
||||
|
||||
// First call: the transfer command; second call: the finally refresh.
|
||||
mockInvoke.mockResolvedValueOnce(undefined);
|
||||
mockInvoke.mockResolvedValueOnce({ type: "remote", session_id: "session-456" });
|
||||
|
||||
await playbackMode.transferToRemote("session-456");
|
||||
|
||||
expect(mockInvoke).toHaveBeenCalledWith("playback_mode_get_current");
|
||||
});
|
||||
|
||||
it("still reconciles to Rust when transferToRemote throws mid-transfer", async () => {
|
||||
const { playbackMode } = await import("./playbackMode");
|
||||
|
||||
// Transfer command fails, leaving the optimistic state possibly wrong.
|
||||
mockInvoke.mockRejectedValueOnce(new Error("boom"));
|
||||
// The finally refresh reads the true mode (Rust never left local).
|
||||
mockInvoke.mockResolvedValueOnce({ type: "local" });
|
||||
|
||||
await expect(playbackMode.transferToRemote("session-456")).rejects.toThrow("boom");
|
||||
|
||||
// The reconciling read must have happened despite the throw.
|
||||
expect(mockInvoke).toHaveBeenCalledWith("playback_mode_get_current");
|
||||
const state = get(playbackMode);
|
||||
expect(state.mode).toBe("local");
|
||||
});
|
||||
});
|
||||
|
||||
describe("clearError", () => {
|
||||
it("should clear transfer error", async () => {
|
||||
const { playbackMode } = await import("./playbackMode");
|
||||
|
||||
@@ -48,12 +48,16 @@ function createPlaybackModeStore() {
|
||||
async function refreshMode(): Promise<void> {
|
||||
try {
|
||||
const rustMode = (await commands.playbackModeGetCurrent()) as RustPlaybackMode;
|
||||
const remoteSessionId = rustMode.type === "remote" ? rustMode.session_id || null : null;
|
||||
|
||||
update((s) => ({
|
||||
...s,
|
||||
mode: rustMode.type,
|
||||
remoteSessionId: rustMode.type === "remote" ? rustMode.session_id || null : null,
|
||||
remoteSessionId,
|
||||
}));
|
||||
// Keep the selected session aligned so the merged UI stores follow the
|
||||
// authoritative mode.
|
||||
sessions.selectSession(remoteSessionId);
|
||||
} catch (error) {
|
||||
console.error("Failed to get playback mode:", error);
|
||||
}
|
||||
@@ -135,6 +139,10 @@ function createPlaybackModeStore() {
|
||||
throw error;
|
||||
} finally {
|
||||
currentTransferAbort = null;
|
||||
// Snap back to whatever the Rust manager actually settled on. If any step
|
||||
// above threw mid-transfer, the optimistic update may not match reality;
|
||||
// Rust is authoritative, so reconcile to it.
|
||||
await refreshMode();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -263,6 +271,9 @@ function createPlaybackModeStore() {
|
||||
console.warn("[PlaybackMode] Failed to clear transferring flag:", e);
|
||||
}
|
||||
currentTransferAbort = null;
|
||||
// Reconcile to the authoritative Rust mode in case a step above threw and
|
||||
// left our optimistic state inconsistent (see transferToRemote).
|
||||
await refreshMode();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -288,6 +299,27 @@ function createPlaybackModeStore() {
|
||||
console.error("[PlaybackMode] Lockscreen-triggered transfer failed:", e),
|
||||
);
|
||||
}
|
||||
return;
|
||||
}
|
||||
|
||||
// The Rust PlaybackModeManager is the single source of truth for routing.
|
||||
// Reconcile our mirror store to it whenever it changes, so the UI and the
|
||||
// event filter in playerEvents.ts can't drift and start routing controls to
|
||||
// the wrong device. We deliberately do NOT reconcile while a transfer is in
|
||||
// flight: transfers emit intermediate mode changes (and briefly hold the
|
||||
// transferring flag), and the transfer functions own the final state.
|
||||
if (event.payload.type === "playback_mode_changed") {
|
||||
const currentState = get({ subscribe });
|
||||
if (currentState.isTransferring) {
|
||||
return;
|
||||
}
|
||||
const mode = event.payload.mode as PlaybackMode;
|
||||
const remoteSessionId =
|
||||
mode === "remote" ? event.payload.session_id ?? null : null;
|
||||
console.log("[PlaybackMode] Backend mode changed →", mode, remoteSessionId);
|
||||
update((s) => ({ ...s, mode, remoteSessionId }));
|
||||
// Keep the selected session in step so the merged UI stores follow.
|
||||
sessions.selectSession(remoteSessionId);
|
||||
}
|
||||
});
|
||||
|
||||
|
||||
Reference in New Issue
Block a user