dtourolle/jellytau
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 11 Wiki Activity

Migrate all IPC call sites to typed tauri-specta commands.* #1

Merged
dtourolle merged 1 commits from ipc-commands-migration into master 2026-06-21 06:48:10 +00:00
Conversation 0 Commits 1 Files Changed 47 +456 -2119
dtourolle commented 2026-06-21 06:47:52 +00:00
Owner
Copy Link

Replace the remaining ~155 untyped invoke() calls across stores, services,
components, and routes with the generated commands.* wrappers from
$lib/api/bindings, so every IPC call is compile-time-checked against the
command signatures.

  • Register repository_get_subtitle_url and repository_get_video_download_url
    in specta_builder() and the invoke_handler; regenerate bindings.ts.
  • Source duplicated wire types (AutoplaySettings, CacheConfig, Session,
    ConnectivityStatus, audio/video settings, etc.) from bindings.
  • Fix two bugs surfaced by the typed wrappers:
    • VideoDownloadButton passed an un-awaited Promise as the stream URL.
    • setAutoplaySettings omitted the required userId argument.
  • Update unit tests asserting the old invoke(name, args) shape.
  • Remove the five param-naming guard tests; the compiler and codegen now
    enforce what they checked.

svelte-check: 0 errors. vitest: green. cargo test --lib: green.

Replace the remaining ~155 untyped invoke() calls across stores, services, components, and routes with the generated commands.* wrappers from $lib/api/bindings, so every IPC call is compile-time-checked against the command signatures. - Register repository_get_subtitle_url and repository_get_video_download_url in specta_builder() and the invoke_handler; regenerate bindings.ts. - Source duplicated wire types (AutoplaySettings, CacheConfig, Session, ConnectivityStatus, audio/video settings, etc.) from bindings. - Fix two bugs surfaced by the typed wrappers: - VideoDownloadButton passed an un-awaited Promise as the stream URL. - setAutoplaySettings omitted the required userId argument. - Update unit tests asserting the old invoke(name, args) shape. - Remove the five param-naming guard tests; the compiler and codegen now enforce what they checked. svelte-check: 0 errors. vitest: green. cargo test --lib: green.
dtourolle added 1 commit 2026-06-21 06:47:52 +00:00
Migrate all IPC call sites to typed tauri-specta commands.*
Some checks failed
🏗️ Build and Test JellyTau / Run Tests (pull_request) Successful in 4m39s
Details
Traceability Validation / Check Requirement Traces (pull_request) Failing after 36s
Details
🏗️ Build and Test JellyTau / Build Android APK (pull_request) Failing after 1m57s
Details
d01c2aab9f 
Replace the remaining ~155 untyped invoke() calls across stores, services,
components, and routes with the generated commands.* wrappers from
$lib/api/bindings, so every IPC call is compile-time-checked against the
command signatures.

- Register repository_get_subtitle_url and repository_get_video_download_url
  in specta_builder() and the invoke_handler; regenerate bindings.ts.
- Source duplicated wire types (AutoplaySettings, CacheConfig, Session,
  ConnectivityStatus, audio/video settings, etc.) from bindings.
- Fix two bugs surfaced by the typed wrappers:
  - VideoDownloadButton passed an un-awaited Promise as the stream URL.
  - setAutoplaySettings omitted the required userId argument.
- Update unit tests asserting the old invoke(name, args) shape.
- Remove the five param-naming guard tests; the compiler and codegen now
  enforce what they checked.

svelte-check: 0 errors. vitest: green. cargo test --lib: green.
dtourolle merged commit 01c6423154 into master 2026-06-21 06:48:10 +00:00
dtourolle deleted branch ipc-commands-migration 2026-06-21 06:48:11 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dtourolle
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dtourolle/jellytau#1
No description provided.
Delete Branch "ipc-commands-migration"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?