🏗️ Build and Test JellyTau / Run Tests (push) Successful in 20m34s
Publish Documentation / Build & publish docs to gitea-pages (push) Successful in 6m6s
Traceability Validation / Check Requirement Traces (push) Successful in 18s
Build & Release / Run Tests (push) Successful in 20m26s
🏗️ Build and Test JellyTau / Android Compile Check (push) Successful in 10m3s
Build & Release / Build Linux (push) Successful in 37m59s
Build & Release / Build Windows (push) Successful in 23m0s
Build & Release / Build Android (push) Successful in 40m26s
Build & Release / Create Release (push) Successful in 1m20s
Bundles this session's work plus the concurrent search/offline/player changes.
Every gate passes on the combined tree: 885 frontend tests, 610 Rust tests,
clippy clean, boundary clean, trace coverage 86%.
Offline video playback — four separate defects, each of which alone stopped it:
DR-133 A completed download's file_path is already absolute (the worker
rewrites it on completion), but the player rooted it a second time and
handed the webview /data/user/0/app//data/user/0/app/videos/x.mp4.
DR-134 The asset protocol was never enabled: no protocol-asset feature and no
assetProtocol config, so convertFileSrc produced URLs nothing answered.
Also silently defeated the cached-thumbnail path, which fails soft to
the server copy and hid it whenever the server was reachable.
DR-137 Tauri's asset protocol answers a range-less request by reading the
whole file into memory, and only advertises Accept-Ranges from inside
its range branch, so the first request never learns ranges exist.
Chromium gave up with PIPELINE_ERROR_READ after ~31s. Local media is
now served by a loopback HTTP server: bounded 4 MiB chunks streamed
from the file handle, every response length-delimited, and a range-less
request answered with one chunk rather than the file. Confined by a
per-session token and to the app data directory, because loopback is
shared between apps on Android.
DR-138 Release builds set usesCleartextTraffic=false, so Android rejected the
request to that server before any I/O. A network-security-config
exempts 127.0.0.1 only; a remote server must still be HTTPS.
Downloads:
DR-135 download_item never records media_type and the reconnect resolver read
that NULL as 'audio', so a movie queued from a media card had its URL
resolved by get_audio_stream_url and completed as an audio-only
transcode. The item's own type now decides.
DR-136 Rows already downloaded that way are requeued on reconnect, since
prevention alone leaves them reading "downloaded" and still unplayable.
Known limitation: a download taken at `original` quality is a byte copy of the
source, so it can be any container. One such file is an AVI holding XVID, which
the webview cannot play in any case — the media server serves it correctly and
Chromium refuses it. That needs either a transcoded download preset or the
native ExoPlayer surface work, and is not addressed here.
Also fixes two ID collisions between concurrent work: DR-143 defined twice
(search vs offline gate) and UT-131 defined twice (Episode Focus hero vs channel
cap). The search requirement is now DR-147 and the channel-cap test UT-141, with
their code references and matrix rows updated.
148 lines
5.3 KiB
Svelte
148 lines
5.3 KiB
Svelte
<!--
|
|
Favourites — everything the viewer has hearted, across every library.
|
|
|
|
Scope tabs are `?scope=`, so a tab is linkable and survives a back press (the
|
|
same convention as the video library `?view=` tabs). Each tab sends an opaque
|
|
`SearchScope`; what it *means* in Jellyfin item types is expanded in Rust
|
|
(`SearchScope::item_types`), never here — see docs/specs/scoped-search-boundary.md.
|
|
|
|
ux-flows §5C.2. TRACES: UR-067 | DR-117
|
|
-->
|
|
<script lang="ts">
|
|
import { onMount, onDestroy } from "svelte";
|
|
import { page } from "$app/stores";
|
|
import { goto } from "$app/navigation";
|
|
import { listen, type UnlistenFn } from "@tauri-apps/api/event";
|
|
import { auth } from "$lib/stores/auth";
|
|
import { isServerReachable } from "$lib/stores/connectivity";
|
|
import { useServerReachabilityReload } from "$lib/composables/useServerReachabilityReload";
|
|
import { useOfflineFilterReload } from "$lib/composables/useOfflineFilterReload";
|
|
import { navigateBack } from "$lib/utils/navigation";
|
|
import { favoriteOverrides, retainFavorites } from "$lib/stores/favorites";
|
|
import LibraryGrid from "$lib/components/library/LibraryGrid.svelte";
|
|
import BackButton from "$lib/components/common/BackButton.svelte";
|
|
import type { MediaItem, Library } from "$lib/api/types";
|
|
import {
|
|
FAVORITE_SCOPES,
|
|
FAVORITE_SCOPE_LABELS,
|
|
resolveFavoritesScope,
|
|
favoritesRouteUrl,
|
|
emptyStateMessage,
|
|
} from "$lib/utils/favoritesView";
|
|
|
|
const scope = $derived(resolveFavoritesScope($page.url.searchParams.get("scope")));
|
|
|
|
let items = $state<MediaItem[]>([]);
|
|
let loading = $state(true);
|
|
let loadError = $state<string | null>(null);
|
|
let unlistenFavorites: UnlistenFn | null = null;
|
|
|
|
// Un-hearting here must remove the card immediately rather than wait for a
|
|
// refetch; a newly hearted item stays put. TRACES: UR-067 | DR-117 | UT-106
|
|
const visibleItems = $derived(retainFavorites(items, $favoriteOverrides));
|
|
|
|
async function load(currentScope = scope) {
|
|
loading = true;
|
|
loadError = null;
|
|
try {
|
|
const repo = auth.getRepository();
|
|
const result = await repo.getFavorites(currentScope, { limit: 500 });
|
|
items = result.items;
|
|
} catch (error) {
|
|
console.error("Failed to load favorites:", error);
|
|
loadError = "Could not load your favourites.";
|
|
items = [];
|
|
} finally {
|
|
loading = false;
|
|
markLoaded();
|
|
}
|
|
}
|
|
|
|
// Reload when the tab changes.
|
|
let loadedScope = "";
|
|
$effect(() => {
|
|
if (scope === loadedScope) return;
|
|
loadedScope = scope;
|
|
load(scope);
|
|
});
|
|
|
|
onMount(async () => {
|
|
// The backend reports ids whose favourite state changed behind our back —
|
|
// a favourite marked in another client, or pending toggles pushed on
|
|
// reconnect. Refetch rather than patch: the scope decides what belongs.
|
|
// TRACES: UR-069 | DR-120
|
|
unlistenFavorites = await listen("favorites-changed", () => {
|
|
load(scope);
|
|
});
|
|
});
|
|
|
|
onDestroy(() => {
|
|
unlistenFavorites?.();
|
|
unlistenFavorites = null;
|
|
});
|
|
|
|
const { markLoaded } = useServerReachabilityReload(() => load(scope));
|
|
// Re-query when the offline downloaded-only gate changes. TRACES: UR-052 | DR-143
|
|
useOfflineFilterReload(() => load(scope));
|
|
|
|
function selectScope(next: (typeof FAVORITE_SCOPES)[number]) {
|
|
if (next === scope) return;
|
|
// replaceState: switching tabs is not a back-press-worthy navigation step.
|
|
goto(favoritesRouteUrl(next), { replaceState: true, noScroll: true });
|
|
}
|
|
|
|
function handleItemClick(item: MediaItem | Library) {
|
|
goto(`/library/${item.id}`);
|
|
}
|
|
</script>
|
|
|
|
<div class="space-y-4">
|
|
<div class="flex items-center gap-3 px-4 pt-4">
|
|
<BackButton onClick={() => navigateBack("/library")} />
|
|
<h1 class="text-2xl font-bold text-white">Favourites</h1>
|
|
</div>
|
|
|
|
<nav class="flex items-center gap-1 px-4" aria-label="Favourite categories">
|
|
{#each FAVORITE_SCOPES as tab (tab)}
|
|
<button
|
|
onclick={() => selectScope(tab)}
|
|
aria-current={tab === scope ? "page" : undefined}
|
|
class="px-4 py-2 rounded-lg text-sm font-medium transition-colors
|
|
{tab === scope
|
|
? 'bg-[var(--color-jellyfin)] text-white'
|
|
: 'text-gray-400 hover:text-white hover:bg-white/10'}"
|
|
>
|
|
{FAVORITE_SCOPE_LABELS[tab]}
|
|
</button>
|
|
{/each}
|
|
</nav>
|
|
|
|
<div class="px-4 pb-8">
|
|
{#if loading}
|
|
<div class="grid grid-cols-2 md:grid-cols-4 lg:grid-cols-6 gap-4">
|
|
{#each Array(12) as _}
|
|
<div class="animate-pulse">
|
|
<div class="aspect-square bg-[var(--color-surface)] rounded-lg mb-2"></div>
|
|
<div class="h-4 bg-[var(--color-surface)] rounded w-3/4"></div>
|
|
</div>
|
|
{/each}
|
|
</div>
|
|
{:else if loadError}
|
|
<p class="text-gray-400 py-12 text-center">{loadError}</p>
|
|
{:else if visibleItems.length === 0}
|
|
<div class="py-16 text-center space-y-2">
|
|
<p class="text-gray-300">{emptyStateMessage(scope)}</p>
|
|
{#if !$isServerReachable}
|
|
<p class="text-sm text-gray-500">
|
|
Offline — showing favourites available on this device.
|
|
</p>
|
|
{/if}
|
|
</div>
|
|
{:else}
|
|
<!-- Card shape follows the media, not the page (§5A.1), so a mixed All
|
|
tab reads as posters, squares and thumbnails side by side. -->
|
|
<LibraryGrid items={visibleItems} onItemClick={handleItemClick} />
|
|
{/if}
|
|
</div>
|
|
</div>
|