dtourolle
14b6a8609d
Each of these was invisible while Linux video played in the webview, and each became reachable the moment mpv started rendering. DR-238 — a transcoded seek re-negotiates the stream on every renderer, not just the webview. `determine_video_seek_strategy` treated `is_hls` as a proxy for "seekable in place", which held only because hls.js was always the HLS renderer: it seeks within the VOD playlist it is handed and lets the server catch up. mpv's HLS demuxer cannot make Jellyfin transcode from a new offset, so with native video on, every transcoded seek became a backend seek that silently did nothing. One cell of the truth table changes; all four webview cells are byte-identical. DR-239 — properties the mpv event loop handles are now observed. libmpv delivers PropertyChange only for properties registered with observe_property, so the `pause` arm was unreachable code that read as implemented: StateChanged was never emitted and the play/pause control never moved. UT-218 asserts the two lists agree, so the class cannot recur. DR-240 — fullscreen moves whatever owns the pixels. requestFullscreen() fullscreens the *document*, which sufficed while the <video> element lived inside it and WebKit scaled it. A native surface is drawn behind the webview at window size, so a document-only fullscreen expanded the page and left the picture at its old size — on WebKitGTK, a maximised window with decorations still holding a strip of the screen. Measured on a 3440x1440 panel: 1361 tall before, 1440 after. DR-241 — a seek issued before mpv has a file to seek in is honoured rather than dropped. loadfile returns as soon as the command is queued, so `time-pos` does not resolve yet and setting it fails. The two callers that always hit that window are resume and a transcoded seek, both of which re-open the stream and then ask for a position; the failed seek was discarded and playback began at zero. Also adds the instrumentation that made the diagnosis possible rather than speculative: an entry log on player_stop, a render-size log that re-fires on change instead of latching once, and decoded-vs-display video geometry on file load. The last of those retired a wrong theory — a picture that does not fill an ultrawide turned out to be a 16:9 source with its letterbox baked in, not a rendering fault.
16 lines
678 B
TypeScript
16 lines
678 B
TypeScript
import { describe, it, expect } from "vitest";
|
|
import { planFullscreen } from "./fullscreenTarget";
|
|
|
|
describe("planFullscreen", () => {
|
|
it("fullscreens only the document when an in-document <video> renders", () => {
|
|
// Unchanged behaviour: WebKit scales the element, the window need not move.
|
|
expect(planFullscreen(false)).toEqual({ document: true, osWindow: false });
|
|
});
|
|
|
|
it("also fullscreens the OS window when a native surface renders", () => {
|
|
// The picture is drawn behind the webview at window size, so a
|
|
// document-only fullscreen leaves it at the old size.
|
|
expect(planFullscreen(true)).toEqual({ document: true, osWindow: true });
|
|
});
|
|
});
|