dtourolle
62873cab3d
Search's instant leg read only downloaded items, so with no downloads it returned nothing and every keystroke fell through to a full Recursive=true server query. It now reads the whole synced catalog through the same availability CTE get_items uses, gated on the same include_catalog_browse flag so search and browse cannot diverge. (UR-065, DR-108) Also fixes three defects found while confirming that: - items_fts grew by a full duplicate index every catalog pass. INSERT OR REPLACE fires no AFTER DELETE trigger without recursive_triggers, so the old index row was orphaned, and a TEXT PRIMARY KEY meant the replacement took a fresh rowid and inserted a second entry. Now a real upsert, with migration 021 rebuilding existing indexes. (DR-110) - DELETE FROM items existed nowhere, so server-side deletions never propagated. Adds a post-crawl mark-and-sweep, scoped to crawled types, skipping downloaded items, and refusing to run after a partial crawl because items.parent_id cascades. (DR-110) - The index omitted MusicArtist, Playlist and People, which search groups results by. Adds them plus people_fts (migration 022). (DR-111) Re-indexing moves from a frontend startup call to a Rust background task with a 6h TTL, so a long session no longer searches a stale catalog and a restart no longer forces a crawl regardless of freshness. (DR-109, IR-030) Downloads gain a lifetime tier. Eviction selected every completed row by age with no download_source filter, so hitting the storage limit deleted the oldest download -- typically one saved deliberately for offline -- to make room for a precached track. It now reclaims only 'auto' rows, and expired ones are reclaimed first, before live cache is evicted. (DR-126, DR-127) Downloaded video and audio-only handoffs now play from disk instead of streaming; the video path had never consulted downloads at all. No transcode is involved: MPV runs video=no and ExoPlayer has no surface for an Audio item. (DR-123 in part, DR-128) FTS queries are built as quoted phrases so apostrophes, hyphens and slashes are data rather than operator syntax, and the item-type filter is bound rather than interpolated. Specs: docs/specs/catalog-index-search.md, docs/specs/read-through-media-cache.md Includes concurrently-developed favourites browsing and background-audio stream-end handling; the two workstreams share offline.rs, lib.rs and online.rs, so no subset of files builds independently.
90 lines
3.0 KiB
TypeScript
90 lines
3.0 KiB
TypeScript
// Favourites overlay — in-session heart state shared across every surface.
|
|
//
|
|
// The durable record lives in Rust (local `user_data` + the Jellyfin server).
|
|
// This store holds only what the *current session* has changed, so a heart
|
|
// tapped on a card is reflected on the detail page and the item vanishes from
|
|
// the Favourites grid without anyone refetching. It is view state, not truth.
|
|
//
|
|
// TRACES: UR-068 | DR-119 | UT-105
|
|
|
|
import { derived, get, writable } from "svelte/store";
|
|
import type { MediaItem } from "$lib/api/types";
|
|
|
|
/** Item id → favourite state set during this session. */
|
|
const overrides = writable<Map<string, boolean>>(new Map());
|
|
|
|
export const favoriteOverrides = { subscribe: overrides.subscribe };
|
|
|
|
/**
|
|
* Record a favourite state locally so every mounted view agrees immediately.
|
|
* Called by the toggle service after the optimistic local write.
|
|
*/
|
|
export function setFavorite(itemId: string, isFavorite: boolean): void {
|
|
overrides.update((map) => {
|
|
const next = new Map(map);
|
|
next.set(itemId, isFavorite);
|
|
return next;
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Forget a session override, so the item's own `userData` is authoritative
|
|
* again. Used when the backend reports the server's state changed underneath
|
|
* us (`favorites-changed`) — the fresh fetch that follows carries the truth.
|
|
*/
|
|
export function clearFavorite(itemId: string): void {
|
|
overrides.update((map) => {
|
|
if (!map.has(itemId)) return map;
|
|
const next = new Map(map);
|
|
next.delete(itemId);
|
|
return next;
|
|
});
|
|
}
|
|
|
|
export function clearAllFavorites(): void {
|
|
overrides.set(new Map());
|
|
}
|
|
|
|
/**
|
|
* Resolution order: a session override wins, then the item's own server-sent
|
|
* `userData`, then "not favourited".
|
|
*
|
|
* The override has to win, or tapping the heart on a card would flip back the
|
|
* moment the (unchanged) item object re-rendered.
|
|
*
|
|
* TRACES: UR-068 | DR-119 | UT-105
|
|
*/
|
|
export function resolveIsFavorite(
|
|
item: Pick<MediaItem, "id" | "userData"> | null | undefined,
|
|
overrideMap: Map<string, boolean>
|
|
): boolean {
|
|
if (!item) return false;
|
|
const override = overrideMap.get(item.id);
|
|
if (override !== undefined) return override;
|
|
return item.userData?.isFavorite ?? false;
|
|
}
|
|
|
|
/** Non-reactive read, for call sites outside a component. */
|
|
export function isFavoriteNow(item: Pick<MediaItem, "id" | "userData">): boolean {
|
|
return resolveIsFavorite(item, get(overrides));
|
|
}
|
|
|
|
/**
|
|
* Drop the items a listing should no longer show once un-favourited.
|
|
*
|
|
* Pure so it can be unit-tested without mounting the page: un-hearting on the
|
|
* Favourites grid must remove the card, while a *newly* favourited item is
|
|
* left alone (it belongs to whatever scope the caller fetched).
|
|
*
|
|
* TRACES: UR-067 | DR-117, DR-119 | UT-106
|
|
*/
|
|
export function retainFavorites<T extends Pick<MediaItem, "id" | "userData">>(
|
|
items: T[],
|
|
overrideMap: Map<string, boolean>
|
|
): T[] {
|
|
return items.filter((item) => resolveIsFavorite(item, overrideMap));
|
|
}
|
|
|
|
/** Count of items still favourited, for "hide the row when empty" decisions. */
|
|
export const hasOverrides = derived(overrides, ($o) => $o.size > 0);
|