dtourolle
62873cab3d
Search's instant leg read only downloaded items, so with no downloads it returned nothing and every keystroke fell through to a full Recursive=true server query. It now reads the whole synced catalog through the same availability CTE get_items uses, gated on the same include_catalog_browse flag so search and browse cannot diverge. (UR-065, DR-108) Also fixes three defects found while confirming that: - items_fts grew by a full duplicate index every catalog pass. INSERT OR REPLACE fires no AFTER DELETE trigger without recursive_triggers, so the old index row was orphaned, and a TEXT PRIMARY KEY meant the replacement took a fresh rowid and inserted a second entry. Now a real upsert, with migration 021 rebuilding existing indexes. (DR-110) - DELETE FROM items existed nowhere, so server-side deletions never propagated. Adds a post-crawl mark-and-sweep, scoped to crawled types, skipping downloaded items, and refusing to run after a partial crawl because items.parent_id cascades. (DR-110) - The index omitted MusicArtist, Playlist and People, which search groups results by. Adds them plus people_fts (migration 022). (DR-111) Re-indexing moves from a frontend startup call to a Rust background task with a 6h TTL, so a long session no longer searches a stale catalog and a restart no longer forces a crawl regardless of freshness. (DR-109, IR-030) Downloads gain a lifetime tier. Eviction selected every completed row by age with no download_source filter, so hitting the storage limit deleted the oldest download -- typically one saved deliberately for offline -- to make room for a precached track. It now reclaims only 'auto' rows, and expired ones are reclaimed first, before live cache is evicted. (DR-126, DR-127) Downloaded video and audio-only handoffs now play from disk instead of streaming; the video path had never consulted downloads at all. No transcode is involved: MPV runs video=no and ExoPlayer has no surface for an Audio item. (DR-123 in part, DR-128) FTS queries are built as quoted phrases so apostrophes, hyphens and slashes are data rather than operator syntax, and the item-type filter is bound rather than interpolated. Specs: docs/specs/catalog-index-search.md, docs/specs/read-through-media-cache.md Includes concurrently-developed favourites browsing and background-audio stream-end handling; the two workstreams share offline.rs, lib.rs and online.rs, so no subset of files builds independently.
70 lines
2.4 KiB
TypeScript
70 lines
2.4 KiB
TypeScript
// Favorites service - Handles toggling favorite status with optimistic updates
|
|
// TRACES: UR-017, UR-068 | DR-021, DR-119
|
|
|
|
import { get } from "svelte/store";
|
|
import { commands } from "$lib/api/bindings";
|
|
import { auth } from "$lib/stores/auth";
|
|
import { isConnected } from "$lib/stores/connectivity";
|
|
import { setFavorite } from "$lib/stores/favorites";
|
|
|
|
/**
|
|
* Toggle the favorite status of an item.
|
|
*
|
|
* Flow:
|
|
* 1. Update local database immediately (optimistic update)
|
|
* 2. Sync to Jellyfin server
|
|
* 3. Mark as synced on success, or leave pending_sync flag on failure
|
|
*
|
|
* @param itemId - The Jellyfin item ID
|
|
* @param currentIsFavorite - The current favorite status
|
|
* @returns The new favorite status
|
|
* @throws Error if not authenticated or database update fails
|
|
*/
|
|
export async function toggleFavorite(
|
|
itemId: string,
|
|
currentIsFavorite: boolean
|
|
): Promise<boolean> {
|
|
const userId = auth.getUserId();
|
|
if (!userId) {
|
|
throw new Error("Not authenticated");
|
|
}
|
|
|
|
const newIsFavorite = !currentIsFavorite;
|
|
|
|
// 1. Update local database first (optimistic update)
|
|
await commands.storageToggleFavorite(userId, itemId, newIsFavorite);
|
|
|
|
// Publish to every mounted view at once, so the heart on a card, the detail
|
|
// page and the Favourites grid never disagree. TRACES: UR-068 | DR-119
|
|
setFavorite(itemId, newIsFavorite);
|
|
|
|
// 2. Sync to Jellyfin server.
|
|
//
|
|
// Only attempt this when we're actually connected. When offline, the server
|
|
// call can hang on a long network timeout rather than failing fast — which
|
|
// blocks the caller (and leaves the favorite button greyed out with a wait
|
|
// cursor) until the request finally gives up, effectively only recovering
|
|
// once we're back online. The local DB write above keeps the pending_sync
|
|
// flag set, so the change still syncs later; we just don't block the UI on
|
|
// an unreachable server here.
|
|
if (get(isConnected)) {
|
|
try {
|
|
const repo = auth.getRepository();
|
|
if (newIsFavorite) {
|
|
await repo.markFavorite(itemId);
|
|
} else {
|
|
await repo.unmarkFavorite(itemId);
|
|
}
|
|
|
|
// 3. Mark as synced
|
|
await commands.storageMarkSynced(userId, itemId);
|
|
} catch (error) {
|
|
console.error("Failed to sync favorite to server:", error);
|
|
// Favorite is stored locally and will be synced later
|
|
// via sync queue (when implemented)
|
|
}
|
|
}
|
|
|
|
return newIsFavorite;
|
|
}
|