dtourolle
9f5f57cba4
Batch of reported bugs and enhancements. UI - Pages no longer inherit the previous page's scroll position (DR-156, UR-072). The shell keeps its scrollers alive across navigation by design, so the element never remounts and its scrollTop survived the route change; SvelteKit restores window scroll, which this app never uses. ScrollMemory records the offset per route and per container: forward moves reset to the top, Back restores where the route was left. - Season header stacks on narrow screens, and the title span gets min-w-0 so it actually truncates instead of overflowing under the action buttons. - Favourites gets a labelled tile at the head of the library grid rather than only an unlabelled heart icon in the header. Playback - Full-screen video on Android hides the system bars (DR-157, UR-066). requestFullscreen() cannot touch the Activity window from inside a WebView, so the control did nothing visible while the bars stayed painted over the video. ImmersiveModeBridge hides them, restored on exit, Escape and teardown. - Background-audio handoff stops leaking its relative timeline (DR-159). background_audio_base was a display-only correction applied in two places while progress reports to Jellyfin, the frontend and media3's own seeks all worked in the relative timeline treating it as absolute — each crossing losing exactly `base` seconds. The conversion now happens once, in the position tick, and inbound seeks resolve through seek_absolute, which re-opens the stream at the requested position because the handoff transcode cannot seek. - Picture-in-picture works on the path that actually plays video (DR-160). canEnterPip demanded a native ExoPlayer surface, but that path is behind a flag defaulting to off, so PiP could never engage. It now accepts the WebView <video> too, keeping the WebView visible and routing play/pause to the element. - Native video is now the default so PiP has a real surface (DR-161). The scrub-regression tests pinned the flag-off path implicitly; they now mock it off explicitly. The native scrub/seek path is not covered by the suite and needs device verification. Watched state - Watched toggle on the episode row, season header, series and movie hero, and the Episode Focus View (DR-158, UR-073). Both backend halves already existed with no caller. storage_set_watched covers a container's episodes so the toggle is honest offline, and QueuedOp::MarkUnplayed gives the sync queue the missing direction. Release - Fix the Android versionCode floor (set-version.sh). v0.5.2 shipped code 5002 under an earlier minor*1000 scheme, but the current minor*100 formula yields 1502 for that version and 1503 for 0.5.3 — so every 0.5.x release built from it was an un-installable downgrade for anyone already on v0.5.2. Widened to 10000 + major*1000000 + minor*1000 + patch (0.5.3 -> 15003). - Bump to 0.5.3.
81 lines
2.8 KiB
TypeScript
81 lines
2.8 KiB
TypeScript
// Presentation logic for the pending-sync queue.
|
|
//
|
|
// The queue's *meaning* lives in Rust (which operations exist, how they push,
|
|
// when one is abandoned — DR-131). What lives here is purely how a row reads on
|
|
// screen: its label, its subtitle, and whether it is currently erroring. Kept
|
|
// out of the component so it can be unit-tested, the same pattern as
|
|
// episodeStrip.ts.
|
|
//
|
|
// TRACES: UR-025 | DR-132 | UT-123
|
|
|
|
import type { SyncQueueItem } from "$lib/api/bindings";
|
|
|
|
/** How each queued operation reads in the list. */
|
|
const OPERATION_LABELS: Record<string, string> = {
|
|
report_playback_start: "Playback started",
|
|
report_playback_stopped: "Watch position",
|
|
update_progress: "Watch position",
|
|
mark_played: "Marked as watched",
|
|
mark_unplayed: "Marked as unwatched",
|
|
mark_favorite: "Added to favourites",
|
|
unmark_favorite: "Removed from favourites",
|
|
playlist_create: "Playlist created",
|
|
playlist_delete: "Playlist deleted",
|
|
playlist_rename: "Playlist renamed",
|
|
playlist_add_items: "Added to playlist",
|
|
playlist_remove_items: "Removed from playlist",
|
|
playlist_reorder_item: "Playlist reordered",
|
|
};
|
|
|
|
/**
|
|
* A human label for a queued operation. An operation this build has no label
|
|
* for still reads as something — an unknown row is the case most worth showing,
|
|
* since it is the one that will end up abandoned.
|
|
*/
|
|
export function describeOperation(operation: string): string {
|
|
return OPERATION_LABELS[operation] ?? operation.replace(/_/g, " ");
|
|
}
|
|
|
|
/** What the row is about: the item's title if the catalog knows it, else its id. */
|
|
export function describeSubject(item: SyncQueueItem): string {
|
|
return item.itemName ?? item.itemId ?? "Unknown item";
|
|
}
|
|
|
|
/**
|
|
* A row is "stuck" once it has failed at least once — that is what justifies
|
|
* showing its error, and what a Retry button acts on.
|
|
*/
|
|
export function isStuck(item: SyncQueueItem): boolean {
|
|
return item.status === "failed" || item.retryCount > 0;
|
|
}
|
|
|
|
export interface PendingSyncSummary {
|
|
total: number;
|
|
stuck: number;
|
|
/** True when every queued row has already failed — retrying needs the server. */
|
|
allStuck: boolean;
|
|
}
|
|
|
|
export function summarize(items: SyncQueueItem[]): PendingSyncSummary {
|
|
const stuck = items.filter(isStuck).length;
|
|
return {
|
|
total: items.length,
|
|
stuck,
|
|
allStuck: items.length > 0 && stuck === items.length,
|
|
};
|
|
}
|
|
|
|
/**
|
|
* Oldest first — the order they will be replayed in, so the list reads as the
|
|
* queue it is. Rows without a timestamp sort last rather than being dropped.
|
|
*/
|
|
export function sortForDisplay(items: SyncQueueItem[]): SyncQueueItem[] {
|
|
return [...items].sort((a, b) => {
|
|
if (!a.createdAt && !b.createdAt) return a.id - b.id;
|
|
if (!a.createdAt) return 1;
|
|
if (!b.createdAt) return -1;
|
|
const diff = Date.parse(a.createdAt) - Date.parse(b.createdAt);
|
|
return diff !== 0 ? diff : a.id - b.id;
|
|
});
|
|
}
|