Playing a video meant asking the server to re-encode it, always. That
decision was made nowhere and written down nowhere, so whoever needed it
re-derived it downstream — the player worked out whether it had been handed
a playlist by looking for ".m3u8" in the URL, in two places. A viewer paid
for a transcode of a file their device could have played untouched, and the
app could not tell them which it was.
One negotiation now produces one self-describing StreamSelection — direct
play, remux or transcode; over a playlist, a plain HTTP file, or a local one
— and every renderer consumes that same answer.
Measured against the development server (Jellyfin 10.11.5), 400 items
sampled for codec mix and 40 put through a real PlaybackInfo negotiation
per profile:
Linux / WebKitGTK (h264 only, 2ch) 3/40 — 7% direct play
Android / ExoPlayer (hevc, ac3/eac3, 6ch) 34/40 — 85% direct play
The library is ~80% hevc, which is why the two diverge so hard. The payoff
is overwhelmingly Android, where 85% of plays were starting a transcode
nobody needed. Linux stays near 7% until libmpv decodes the picture — the
h264-only profile is a WebKitGTK constraint, not a JellyTau choice.
DR-219 StreamSelection: url + tagged Transport (hls/progressive/localFile)
+ PlaybackKind (directPlay/directStream/transcode) + the negotiated
rendition + this source's ladder + a needs_transcoding flag derived
in Rust so the rule is answered once. Both enums are serde-tagged
so the frontend matches a discriminant, not a substring. The paths
that never negotiate get the same shape from Rust rather than
assembling one — media_local_selection for a downloaded file,
LiveStreamInfo.transport for a live channel — so there is no second
place where a transport is decided.
DR-220 The ceiling becomes two levels: a durable device default (Settings,
persisted) and a per-playback override the in-player picker sets.
The picker had called itself a "this film, this connection" control
since it was written but wrote the process-wide default, so dropping
one awkward film to 2 Mbps silently capped every video played
afterwards for the rest of the process, with Settings still showing
the old value. The override is cleared whenever playback moves to a
new item, which stops it surviving into an autoplayed next episode.
effective_streaming_quality() is the single resolution point.
DR-221 The quality picker is filled from what this media source can offer.
Rust marks a rung exceeds_source when its ceiling is at or above the
source's own bitrate — such a rung is another way to spell Original
— and the frontend does not draw those. Original is never marked; a
source whose bitrate the server does not report marks nothing, which
keeps every rung offered.
DR-222 Direct play and direct stream are negotiated, with two client-side
overrides on top because the server's answer is right about the file
and wrong about what this app will do with it: undecodable audio
(Jellyfin 10.11.5 honours a DirectPlayProfile's container and video
codec but ignores its audio codec, so it offers direct play for an
E-AC-3 track the webview renders in silence) and a viewer-pinned
audio track the file does not default to. A direct stream is a remux
and is deliberately not counted as transcoding.
DR-223 Dropped on measurement, not deferred. A master playlist from this
server carries exactly one EXT-X-STREAM-INF: Jellyfin builds it from
the single rendition the request asked for rather than publishing a
ladder. So there is no adaptation for hls.js to be preserving and
none mpv would lose — the claim that there was, in
playback-backend-unification.md, does not hold. Recorded rather than
deleted because it is a measurement: a server that does publish a
ladder would change the answer.
DR-224 Every backend consumes the same selection. The queue item carries
the transport, so player_seek_video picks its seek strategy from the
backend's decision instead of the last stream_url.contains(".m3u8")
in the codebase. Items queued by a path that never negotiated carry
None and fall back to needs_transcoding, which is exact rather than
a guess because every transcode this app requests is HLS (DR-140).
The frontend loader decision moves to streamTransport.ts so it can be
tested: the two cases that pin it are the ones that failed against the old
implementation — a progressive stream whose URL contains ".m3u8" must not
get an HLS loader, and an HLS stream whose URL contains none must.
Also verified the URL the direct-play branch builds actually serves playable
bytes: 206, video/mp4, valid ISO-BMFF, and a mid-file range works, so
seeking a direct play works.
The spec is folded into docs/architecture/{01,02,03} and deleted, per the
rule that docs/specs holds only work that has not shipped. DR-121 leaves
read-through-media-cache.md with a pointer; that spec keeps its capture half.
Not verified: real playback on a device. Direct play changes what actually
gets played, and neither fixtures nor curl prove the WebKitGTK and ExoPlayer
paths render it.
94 lines
3.6 KiB
TypeScript
94 lines
3.6 KiB
TypeScript
/**
|
|
* The loader is chosen from the backend's `transport` tag, never from the URL.
|
|
*
|
|
* TRACES: UR-079 | DR-224 | UT-213
|
|
*/
|
|
|
|
import { describe, expect, it } from "vitest";
|
|
import { elementSrcFor, videoLoaderFor, type LoaderCapabilities } from "./streamTransport";
|
|
import type { StreamSelection, Transport } from "$lib/api/bindings";
|
|
|
|
const MODERN: LoaderCapabilities = { hlsJsSupported: true, nativeHlsSupported: false };
|
|
const SAFARI: LoaderCapabilities = { hlsJsSupported: false, nativeHlsSupported: true };
|
|
const NEITHER: LoaderCapabilities = { hlsJsSupported: false, nativeHlsSupported: false };
|
|
|
|
function selection(transport: Transport, url: string): Pick<StreamSelection, "url" | "transport"> {
|
|
return { url, transport };
|
|
}
|
|
|
|
describe("videoLoaderFor", () => {
|
|
it("attaches hls.js when the backend says HLS and hls.js is available", () => {
|
|
expect(videoLoaderFor(selection({ type: "hls" }, "https://s/master.m3u8"), MODERN)).toBe(
|
|
"hlsjs",
|
|
);
|
|
});
|
|
|
|
it("falls back to the element's own HLS loader when hls.js is unavailable", () => {
|
|
expect(videoLoaderFor(selection({ type: "hls" }, "https://s/master.m3u8"), SAFARI)).toBe(
|
|
"nativeHls",
|
|
);
|
|
});
|
|
|
|
it("loads a progressive stream directly", () => {
|
|
expect(
|
|
videoLoaderFor(
|
|
selection({ type: "progressive" }, "https://s/Videos/1/stream?static=true"),
|
|
MODERN,
|
|
),
|
|
).toBe("direct");
|
|
});
|
|
|
|
it("loads a local file directly", () => {
|
|
expect(
|
|
videoLoaderFor(selection({ type: "localFile" }, "http://127.0.0.1:9/media/x.mkv"), MODERN),
|
|
).toBe("direct");
|
|
});
|
|
|
|
// ---------------------------------------------------------------------
|
|
// The two cases the `.m3u8` substring check gets wrong. These are the
|
|
// reason the field exists; both fail against a URL-sniffing implementation.
|
|
// ---------------------------------------------------------------------
|
|
|
|
it("does NOT attach hls.js to a progressive stream whose URL happens to end .m3u8", () => {
|
|
// A direct play served from a path containing the substring — nothing stops
|
|
// a server, a proxy, or a local cache from producing this.
|
|
expect(
|
|
videoLoaderFor(selection({ type: "progressive" }, "https://s/files/movie.m3u8.mp4"), MODERN),
|
|
).toBe("direct");
|
|
expect(
|
|
videoLoaderFor(selection({ type: "progressive" }, "https://s/x?name=master.m3u8"), MODERN),
|
|
).toBe("direct");
|
|
});
|
|
|
|
it("DOES attach hls.js to an HLS stream whose URL does not contain .m3u8", () => {
|
|
// Jellyfin's own transcoding URLs are not required to end in `.m3u8`, and a
|
|
// DASH or query-routed playlist endpoint never would.
|
|
expect(videoLoaderFor(selection({ type: "hls" }, "https://s/Videos/1/hls"), MODERN)).toBe(
|
|
"hlsjs",
|
|
);
|
|
expect(
|
|
videoLoaderFor(selection({ type: "hls" }, "https://s/stream?format=playlist"), SAFARI),
|
|
).toBe("nativeHls");
|
|
});
|
|
|
|
it("falls back to direct when HLS is requested but nothing can play it", () => {
|
|
expect(videoLoaderFor(selection({ type: "hls" }, "https://s/master.m3u8"), NEITHER)).toBe(
|
|
"direct",
|
|
);
|
|
});
|
|
});
|
|
|
|
describe("elementSrcFor", () => {
|
|
it("empties the element's src only when hls.js drives it", () => {
|
|
expect(elementSrcFor(selection({ type: "hls" }, "https://s/master.m3u8"), MODERN)).toBe("");
|
|
expect(elementSrcFor(selection({ type: "hls" }, "https://s/master.m3u8"), SAFARI)).toBe(
|
|
"https://s/master.m3u8",
|
|
);
|
|
});
|
|
|
|
it("keeps the src for a progressive stream that looks like a playlist", () => {
|
|
const s = selection({ type: "progressive" }, "https://s/files/movie.m3u8.mp4");
|
|
expect(elementSrcFor(s, MODERN)).toBe("https://s/files/movie.m3u8.mp4");
|
|
});
|
|
});
|