dtourolle
9f5f57cba4
Batch of reported bugs and enhancements. UI - Pages no longer inherit the previous page's scroll position (DR-156, UR-072). The shell keeps its scrollers alive across navigation by design, so the element never remounts and its scrollTop survived the route change; SvelteKit restores window scroll, which this app never uses. ScrollMemory records the offset per route and per container: forward moves reset to the top, Back restores where the route was left. - Season header stacks on narrow screens, and the title span gets min-w-0 so it actually truncates instead of overflowing under the action buttons. - Favourites gets a labelled tile at the head of the library grid rather than only an unlabelled heart icon in the header. Playback - Full-screen video on Android hides the system bars (DR-157, UR-066). requestFullscreen() cannot touch the Activity window from inside a WebView, so the control did nothing visible while the bars stayed painted over the video. ImmersiveModeBridge hides them, restored on exit, Escape and teardown. - Background-audio handoff stops leaking its relative timeline (DR-159). background_audio_base was a display-only correction applied in two places while progress reports to Jellyfin, the frontend and media3's own seeks all worked in the relative timeline treating it as absolute — each crossing losing exactly `base` seconds. The conversion now happens once, in the position tick, and inbound seeks resolve through seek_absolute, which re-opens the stream at the requested position because the handoff transcode cannot seek. - Picture-in-picture works on the path that actually plays video (DR-160). canEnterPip demanded a native ExoPlayer surface, but that path is behind a flag defaulting to off, so PiP could never engage. It now accepts the WebView <video> too, keeping the WebView visible and routing play/pause to the element. - Native video is now the default so PiP has a real surface (DR-161). The scrub-regression tests pinned the flag-off path implicitly; they now mock it off explicitly. The native scrub/seek path is not covered by the suite and needs device verification. Watched state - Watched toggle on the episode row, season header, series and movie hero, and the Episode Focus View (DR-158, UR-073). Both backend halves already existed with no caller. storage_set_watched covers a container's episodes so the toggle is honest offline, and QueuedOp::MarkUnplayed gives the sync queue the missing direction. Release - Fix the Android versionCode floor (set-version.sh). v0.5.2 shipped code 5002 under an earlier minor*1000 scheme, but the current minor*100 formula yields 1502 for that version and 1503 for 0.5.3 — so every 0.5.x release built from it was an un-installable downgrade for anyone already on v0.5.2. Widened to 10000 + major*1000000 + minor*1000 + patch (0.5.3 -> 15003). - Bump to 0.5.3.
80 lines
2.8 KiB
TypeScript
80 lines
2.8 KiB
TypeScript
import { describe, it, expect, beforeEach } from "vitest";
|
|
import { ScrollMemory, classifyNavigation } from "./scrollRestore";
|
|
|
|
describe("classifyNavigation", () => {
|
|
it("treats the initial page load as an entry", () => {
|
|
expect(classifyNavigation({ type: "enter" })).toBe("enter");
|
|
});
|
|
|
|
it("treats back/forward gestures as a popstate", () => {
|
|
expect(classifyNavigation({ type: "popstate" })).toBe("popstate");
|
|
});
|
|
|
|
it("treats link and goto navigations as forward moves", () => {
|
|
expect(classifyNavigation({ type: "link" })).toBe("forward");
|
|
expect(classifyNavigation({ type: "goto" })).toBe("forward");
|
|
expect(classifyNavigation({ type: "form" })).toBe("forward");
|
|
});
|
|
});
|
|
|
|
describe("ScrollMemory", () => {
|
|
let memory: ScrollMemory;
|
|
|
|
beforeEach(() => {
|
|
memory = new ScrollMemory();
|
|
});
|
|
|
|
// The bug: a scroll container that lives in a persistent layout keeps its
|
|
// offset across a forward navigation, so a page opened from a scrolled list
|
|
// starts part-way down. A forward move must always land at the top.
|
|
it("resets to the top on a forward navigation, even from a scrolled page", () => {
|
|
memory.save("/library", 1200);
|
|
|
|
expect(memory.decide("/library/abc123", "forward")).toEqual({ kind: "reset" });
|
|
});
|
|
|
|
it("resets to the top when navigating forward to a page seen before", () => {
|
|
memory.save("/library", 1200);
|
|
memory.save("/search", 340);
|
|
|
|
// Re-entering /library by tapping a nav link is a fresh visit, not a Back.
|
|
expect(memory.decide("/library", "forward")).toEqual({ kind: "reset" });
|
|
});
|
|
|
|
it("restores the saved offset on Back", () => {
|
|
memory.save("/library", 1200);
|
|
|
|
expect(memory.decide("/library", "popstate")).toEqual({ kind: "restore", top: 1200 });
|
|
});
|
|
|
|
it("restores the top when Back targets a page with no saved offset", () => {
|
|
expect(memory.decide("/library", "popstate")).toEqual({ kind: "restore", top: 0 });
|
|
});
|
|
|
|
it("keeps offsets per route rather than sharing one across pages", () => {
|
|
memory.save("/library", 1200);
|
|
memory.save("/search", 340);
|
|
|
|
expect(memory.decide("/library", "popstate")).toEqual({ kind: "restore", top: 1200 });
|
|
expect(memory.decide("/search", "popstate")).toEqual({ kind: "restore", top: 340 });
|
|
});
|
|
|
|
it("leaves the container alone on the initial load", () => {
|
|
expect(memory.decide("/", "enter")).toEqual({ kind: "none" });
|
|
});
|
|
|
|
it("overwrites a stale offset when the same route is saved again", () => {
|
|
memory.save("/library", 1200);
|
|
memory.save("/library", 80);
|
|
|
|
expect(memory.decide("/library", "popstate")).toEqual({ kind: "restore", top: 80 });
|
|
});
|
|
|
|
it("forgets nothing on decide, so a repeated Back still restores", () => {
|
|
memory.save("/library", 1200);
|
|
|
|
memory.decide("/library", "popstate");
|
|
expect(memory.decide("/library", "popstate")).toEqual({ kind: "restore", top: 1200 });
|
|
});
|
|
});
|