dtourolle/pyPhotoAlbum
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix ghost pages having no size
All checks were successful
Python CI / test (push) Successful in 59s
Details
Lint / lint (push) Successful in 1m8s
Details
Tests / test (3.10) (push) Successful in 45s
Details
Tests / test (3.11) (push) Successful in 45s
Details
Tests / test (3.9) (push) Successful in 44s
Details

Browse Source
This commit is contained in:
Duncan Tourolle 2025-10-29 20:50:33 +01:00
parent aa02506d4c
commit 375e87ec84
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
pyPhotoAlbum/gl_widget.py
View File

@ -1098,13 +1098,12 @@ class GLWidget(UndoableInteractionMixin, QOpenGLWidget):
if not hasattr(main_window, 'project'): if not hasattr(main_window, 'project'):
return False return False
# Get full layout with ghosts to determine insertion position # Get page positions which includes ghosts
layout_with_ghosts = main_window.project.calculate_page_layout_with_ghosts()
page_positions = self._get_page_positions() page_positions = self._get_page_positions()
# Track which index in the page list corresponds to each position # Check each position for ghost pages
ghost_index = 0 for idx, (page_type, page_or_ghost, y_offset) in enumerate(page_positions):
for idx, ((page_type, page_obj_layout, logical_pos), (_, page_or_ghost, y_offset)) in enumerate(zip(layout_with_ghosts, page_positions)): # Skip non-ghost pages
if page_type != 'ghost': if page_type != 'ghost':
continue continue
@ -1129,8 +1128,8 @@ class GLWidget(UndoableInteractionMixin, QOpenGLWidget):
# Check if click is anywhere on the ghost page (entire page is clickable) # Check if click is anywhere on the ghost page (entire page is clickable)
if renderer.is_point_in_page(x, y): if renderer.is_point_in_page(x, y):
# User clicked the ghost page! # User clicked the ghost page!
# Calculate the insertion index (count real pages before this ghost) # Calculate the insertion index (count real pages before this ghost in page_positions)
insert_index = sum(1 for i, (pt, _, _) in enumerate(layout_with_ghosts) if i < idx and pt == 'page') insert_index = sum(1 for i, (pt, _, _) in enumerate(page_positions) if i < idx and pt == 'page')
print(f"Ghost page clicked at index {insert_index} - inserting new page in place") print(f"Ghost page clicked at index {insert_index} - inserting new page in place")