From 5ce63944168395a56b8c15140fdcba148d672079 Mon Sep 17 00:00:00 2001 From: Duncan Tourolle Date: Sun, 30 Aug 2026 22:42:26 +0200 Subject: [PATCH] =?UTF-8?q?chore:=20update=20KPN=20=E2=80=94=20diagnostics?= =?UTF-8?q?.hpp=20includes=20the=20=20it=20uses?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit af9da7d on top of 5375ab4, and the reason it exists is this repository. kpn/diagnostics.hpp declares NetworkSnapshot with two std::vector members and has never included . It compiled everywhere we build because something earlier in each translation unit dragged the definition in first. src/benchmark.hpp includes before its own , and under Debian 12 / GCC 12 -- the CI image, and nothing we develop on -- nothing supplies it, so the two members fail to declare and every later use of .nodes or .channels fails after them. The errors all name benchmark.hpp, so it reads as our bug until you look at the first line of compiler output rather than the last. This bump also crosses the four perf/phase0-harness commits between 5375ab4 and the pin, which is a larger move than a header fix and worth being explicit about. Checked rather than assumed: the two tests failing in CI fail identically with the pin at 771b9f8 plus the include fix alone, so they are not this bump's doing. The perf work changes the scheduler and pool; the failures are tracker extinction-window logic and are reachable with no pool at all. Also found while checking KPN's public headers standalone under GCC 12, and NOT fixed there: network.hpp names IChannelProbe (channel.hpp:557) without including channel.hpp -- the same latent bug, waiting for the same kind of consumer. web_debug.hpp needs httplib.h, which is an optional external dependency and not a defect. --- external/KPN | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/external/KPN b/external/KPN index 771b9f8..af9da7d 160000 --- a/external/KPN +++ b/external/KPN @@ -1 +1 @@ -Subproject commit 771b9f85938dbc1ac449ed4a730fa20ec298609e +Subproject commit af9da7db81cbc28e8f13e7cff683a0218a259881