Call the tool Compose, since that is what its panel says
Benchmarks / CPU and I/O (per commit) (push) Successful in 14m35s
Benchmarks / Frame budget (on demand) (push) Skipped
Build and test / Desktop (Linux) (push) Failing after 1h20m20s
Build and test / Layer separation (push) Successful in 51s
Traceability / Requirement traces (push) Successful in 2m8s
🐳 Android image / Build and push (push) Successful in 5s
Build and test / android-image (push) Successful in 5s
Build and test / Android (aarch64) (push) Successful in 1h5m51s
Benchmarks / CPU and I/O (per commit) (push) Successful in 14m35s
Benchmarks / Frame budget (on demand) (push) Skipped
Build and test / Desktop (Linux) (push) Failing after 1h20m20s
Build and test / Layer separation (push) Successful in 51s
Traceability / Requirement traces (push) Successful in 2m8s
🐳 Android image / Build and push (push) Successful in 5s
Build and test / android-image (push) Successful in 5s
Build and test / Android (aarch64) (push) Successful in 1h5m51s
The rail entry read "Crop" while the panel it opens is headed COMPOSE and the button leaving it said "Done Cropping". One mode, three names, and the odd one out was named after a single control rather than after the decision — which is what made cropping look like a category of its own in the first place. Straightening, the quarter turns and the flips are already in that panel, and perspective will be. `ViewMode.crop` keeps its name: it identifies a canvas interaction, which is exactly what it still is. Found by looking at the running application rather than by reading, which is also how the two halves of this were noticed to disagree at all. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -2248,8 +2248,14 @@ in property <bool> panel-visible: true;
|
||||
// Names the mode being left rather than saying
|
||||
// "Done", which was unambiguous while there was
|
||||
// one mode and would not be with two.
|
||||
// "Composing", matching what the rail entry and
|
||||
// the panel both call this mode. It said "Done
|
||||
// Cropping" while the tool said Crop; naming the
|
||||
// exit after one of the mode's controls, when the
|
||||
// rail beside it named the mode, would be the same
|
||||
// control answering to two words.
|
||||
text: root.cropping
|
||||
? "Done Cropping"
|
||||
? "Done Composing"
|
||||
: (root.repairing ? "Done Repairing" : "Done Masking");
|
||||
active: true;
|
||||
clicked => { root.mode-picked(ViewMode.photo); }
|
||||
|
||||
@@ -140,7 +140,15 @@ export component ToolRail inherits Rectangle {
|
||||
// arrives this file's share of the work is one line.
|
||||
private property <[Tool]> tools: [
|
||||
{ icon: "photo", label: "Photo", mode: ViewMode.photo },
|
||||
{ icon: "crop", label: "Crop", mode: ViewMode.crop },
|
||||
// "Compose", not "Crop", and the panel it opens says the same. The
|
||||
// tool arms a crop gesture, but what it is *for* is deciding the
|
||||
// frame — straightening, the quarter turns and the flips are in that
|
||||
// panel too, and perspective will be. Naming the tool after one of its
|
||||
// controls was what made cropping look like a category of its own.
|
||||
//
|
||||
// `ViewMode.crop` keeps its name: it identifies a canvas interaction,
|
||||
// which is exactly what it still is.
|
||||
{ icon: "crop", label: "Compose", mode: ViewMode.crop },
|
||||
{ icon: "mask", label: "Local", mode: ViewMode.local },
|
||||
{ icon: "repair", label: "Repair", mode: ViewMode.spots },
|
||||
];
|
||||
|
||||
Reference in New Issue
Block a user