dtourolle/DarkRoom
1
0
Fork 0
Code Issues 39 Pull Requests Actions Packages Projects Releases 20 Wiki Activity

Drop three trait imports Android does not need

Browse Source 
The Linux store is built on `keyring::Entry`, whose set_password,
get_password and delete_credential are inherent methods. The Android one
is built on `keyring_core::Entry`, where they are inherent too -- so the
`CredentialApi` import that each of its three methods opened with was
doing nothing, and said so on every Android build.

`CredentialStoreApi` a few lines above is a different matter and stays:
`build` really does come from that trait.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
dtourolle
2026-08-27 12:16:17 +02:00
co-authored by Claude Opus 5
parent d777f7f44d
commit 721efbc371
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/dr-plat/src/secrets.rs
-6
View File
@@ -222,22 +222,16 @@ impl Default for PlatformSecretStore {
#[cfg(target_os = "android")] #[cfg(target_os = "android")]
impl SecretStore for PlatformSecretStore { impl SecretStore for PlatformSecretStore {
fn store(&self, secret_ref: &SecretRef, secret: &str) -> Result<(), SecretError> { fn store(&self, secret_ref: &SecretRef, secret: &str) -> Result<(), SecretError> {
use keyring_core::api::CredentialApi;
self.entry(secret_ref)? self.entry(secret_ref)?
.set_password(secret) .set_password(secret)
.map_err(map_err) .map_err(map_err)
} }
fn retrieve(&self, secret_ref: &SecretRef) -> Result<String, SecretError> { fn retrieve(&self, secret_ref: &SecretRef) -> Result<String, SecretError> {
use keyring_core::api::CredentialApi;
self.entry(secret_ref)?.get_password().map_err(map_err) self.entry(secret_ref)?.get_password().map_err(map_err)
} }
fn delete(&self, secret_ref: &SecretRef) -> Result<(), SecretError> { fn delete(&self, secret_ref: &SecretRef) -> Result<(), SecretError> {
use keyring_core::api::CredentialApi;
match self.entry(secret_ref)?.delete_credential() { match self.entry(secret_ref)?.delete_credential() {
Ok(()) => Ok(()), Ok(()) => Ok(()),
// Logout must be idempotent, as on Linux. // Logout must be idempotent, as on Linux.