FR-CULL-5 — Bind the burst representative override, and fix a stale comment #20

New Issue

2026-09-05T16:20:10Z

dtourolle commented

2026-09-05 16:20:10 +00:00

Two threads left hanging by FR-CULL-5, both recorded in docs/outstanding.md §2.

1. `choose_representative` is bound to no gesture

dr_catalog::bursts::choose_representative is written and tested. Nothing calls it from the interface, so today the only way to override a burst's representative is to expand the burst.

The representative is currently the earliest frame — a fact about the clock, chosen deliberately so that nothing scores or rejects a photograph. That is the right default and the wrong only option: the point of a burst is that one of them is better.

Bind it. Setting the representative from an expanded burst is the obvious gesture.
Add it to the gesture book (cargo run -p traceability -- gestures).

2. A stale forward reference in `dr-face`

core/dr-face/src/calibrate.rs still says "since FR-CULL-5 already groups bursts, positives are bootstrapped from bursts". It bootstraps from confirmed labels. The comment was a forward reference when written and is now simply wrong.

Correct it to describe what the code does.

Small, but it is the kind of comment a reader trusts.

Two threads left hanging by FR-CULL-5, both recorded in `docs/outstanding.md` §2. ## 1. `choose_representative` is bound to no gesture `dr_catalog::bursts::choose_representative` is written and tested. Nothing calls it from the interface, so today the only way to override a burst's representative is to expand the burst. The representative is currently the earliest frame — a fact about the clock, chosen deliberately so that nothing scores or rejects a photograph. That is the right default and the wrong only option: the point of a burst is that one of them is better. - [ ] Bind it. Setting the representative from an expanded burst is the obvious gesture. - [ ] Add it to the gesture book (`cargo run -p traceability -- gestures`). ## 2. A stale forward reference in `dr-face` `core/dr-face/src/calibrate.rs` still says *"since FR-CULL-5 already groups bursts, positives are bootstrapped from bursts"*. It bootstraps from **confirmed labels**. The comment was a forward reference when written and is now simply wrong. - [ ] Correct it to describe what the code does. Small, but it is the kind of comment a reader trusts.

dtourolle added the ui size:S culling labels 2026-09-05 16:20:10 +00:00

dtourolle referenced this issue

2026-09-05 16:20:49 +00:00

FR-CULL-6 — Compare and survey #18

dtourolle commented

2026-09-11 21:54:21 +00:00

Both threads done. 1c5c55b binds choose_representative to a ring on each frame of an open burst and regenerates the gesture book; 43652bd corrects the calibrate.rs comment to say positives come from confirmed labels and nothing else.

Both threads done. 1c5c55b binds choose_representative to a ring on each frame of an open burst and regenerates the gesture book; 43652bd corrects the calibrate.rs comment to say positives come from confirmed labels and nothing else.

dtourolle closed this issue

2026-09-11 21:54:22 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dtourolle/DarkRoom#20

FR-CULL-5 — Bind the burst representative override, and fix a stale comment #20

1. choose_representative is bound to no gesture

2. A stale forward reference in dr-face

1. `choose_representative` is bound to no gesture

2. A stale forward reference in `dr-face`