🏗️ Build and Test JellyTau / Run Tests (push) Successful in 20m34s
Publish Documentation / Build & publish docs to gitea-pages (push) Successful in 6m6s
Traceability Validation / Check Requirement Traces (push) Successful in 18s
Build & Release / Run Tests (push) Successful in 20m26s
🏗️ Build and Test JellyTau / Android Compile Check (push) Successful in 10m3s
Build & Release / Build Linux (push) Successful in 37m59s
Build & Release / Build Windows (push) Successful in 23m0s
Build & Release / Build Android (push) Successful in 40m26s
Build & Release / Create Release (push) Successful in 1m20s
Bundles this session's work plus the concurrent search/offline/player changes.
Every gate passes on the combined tree: 885 frontend tests, 610 Rust tests,
clippy clean, boundary clean, trace coverage 86%.
Offline video playback — four separate defects, each of which alone stopped it:
DR-133 A completed download's file_path is already absolute (the worker
rewrites it on completion), but the player rooted it a second time and
handed the webview /data/user/0/app//data/user/0/app/videos/x.mp4.
DR-134 The asset protocol was never enabled: no protocol-asset feature and no
assetProtocol config, so convertFileSrc produced URLs nothing answered.
Also silently defeated the cached-thumbnail path, which fails soft to
the server copy and hid it whenever the server was reachable.
DR-137 Tauri's asset protocol answers a range-less request by reading the
whole file into memory, and only advertises Accept-Ranges from inside
its range branch, so the first request never learns ranges exist.
Chromium gave up with PIPELINE_ERROR_READ after ~31s. Local media is
now served by a loopback HTTP server: bounded 4 MiB chunks streamed
from the file handle, every response length-delimited, and a range-less
request answered with one chunk rather than the file. Confined by a
per-session token and to the app data directory, because loopback is
shared between apps on Android.
DR-138 Release builds set usesCleartextTraffic=false, so Android rejected the
request to that server before any I/O. A network-security-config
exempts 127.0.0.1 only; a remote server must still be HTTPS.
Downloads:
DR-135 download_item never records media_type and the reconnect resolver read
that NULL as 'audio', so a movie queued from a media card had its URL
resolved by get_audio_stream_url and completed as an audio-only
transcode. The item's own type now decides.
DR-136 Rows already downloaded that way are requeued on reconnect, since
prevention alone leaves them reading "downloaded" and still unplayable.
Known limitation: a download taken at `original` quality is a byte copy of the
source, so it can be any container. One such file is an AVI holding XVID, which
the webview cannot play in any case — the media server serves it correctly and
Chromium refuses it. That needs either a transcoded download preset or the
native ExoPlayer surface work, and is not addressed here.
Also fixes two ID collisions between concurrent work: DR-143 defined twice
(search vs offline gate) and UT-131 defined twice (Episode Focus hero vs channel
cap). The search requirement is now DR-147 and the channel-cap test UT-141, with
their code references and matrix rows updated.
134 lines
4.8 KiB
TypeScript
134 lines
4.8 KiB
TypeScript
/**
|
|
* Pure layout-shell visibility rules for the app's bottom UI (mini player
|
|
* stacked over the bottom nav).
|
|
*
|
|
* These rules used to live as inline `$derived` booleans scattered across the
|
|
* root and library `+layout.svelte` files and diverged per platform/route.
|
|
*
|
|
* The overlap bug ("last row hidden behind the nav") is now solved
|
|
* STRUCTURALLY, not by these rules: the bottom UI is rendered as an in-flow
|
|
* flex child below the scroller (see BottomUi.svelte), so the scroller is
|
|
* physically bounded above it and can never render behind it. There is no
|
|
* measurement and no reserved padding. These functions only decide *whether*
|
|
* each piece is visible on a given route.
|
|
*
|
|
* Keeping them pure makes the visibility contract unit-testable.
|
|
*
|
|
* TRACES: UR-005 | DR-009
|
|
*/
|
|
|
|
import { isSearchRoute } from "$lib/utils/searchScope";
|
|
|
|
export interface BottomUiVisibilityInput {
|
|
/** Current route pathname, e.g. `$page.url.pathname`. */
|
|
pathname: string;
|
|
/** Whether the user is authenticated. */
|
|
isAuthenticated: boolean;
|
|
}
|
|
|
|
/**
|
|
* The bottom nav is shown on every authenticated route except the full-screen
|
|
* player and the login route.
|
|
*/
|
|
export function showBottomNav({
|
|
pathname,
|
|
isAuthenticated,
|
|
}: BottomUiVisibilityInput): boolean {
|
|
return (
|
|
isAuthenticated &&
|
|
!pathname.startsWith("/player/") &&
|
|
!pathname.startsWith("/login")
|
|
);
|
|
}
|
|
|
|
/**
|
|
* The global (root-owned) mini player is shown on every route except the
|
|
* full-screen player, login, and settings. Crucially this is NOT gated on
|
|
* platform or on `/library` — the root owns the mini player everywhere, so the
|
|
* library route must never render its own second one.
|
|
*/
|
|
export function showGlobalMiniPlayer({ pathname }: { pathname: string }): boolean {
|
|
return (
|
|
!pathname.startsWith("/player/") &&
|
|
!pathname.startsWith("/login") &&
|
|
!pathname.startsWith("/settings")
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Routes that render their own full-height flex column (header + scroller +
|
|
* their own in-flow BottomUi). The root leaves these as a plain clipped box and
|
|
* does not render its own BottomUi. Every other route renders into the root's
|
|
* scroller, with the root's in-flow BottomUi as a flex sibling below it.
|
|
*/
|
|
export function routeOwnsLayout({ pathname }: { pathname: string }): boolean {
|
|
return (
|
|
pathname.startsWith("/library") ||
|
|
pathname.startsWith("/player/") ||
|
|
pathname.startsWith("/login")
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Whether the root layout should render the shared app header (logo, desktop
|
|
* nav, and the account menu) for this route.
|
|
*
|
|
* Routes that own their layout (library) render their own AppHeader, so the
|
|
* root must not double it up. `/settings` owns its content but deliberately has
|
|
* no account menu (the user is already there). `/player/*` and `/login` are
|
|
* immersive/chrome-free. Everything else authenticated (`/`, `/search`,
|
|
* `/downloads`) gets the header from the root — the whole point of UR-054.
|
|
*
|
|
* TRACES: UR-054 | DR-076
|
|
*/
|
|
export function showGlobalHeader({
|
|
pathname,
|
|
isAuthenticated,
|
|
}: BottomUiVisibilityInput): boolean {
|
|
return (
|
|
isAuthenticated &&
|
|
!routeOwnsLayout({ pathname }) &&
|
|
!pathname.startsWith("/settings")
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Whether the header renders its search box on this route (md+ only; below md
|
|
* the bottom-nav Search tab and /search's own input serve that role).
|
|
*
|
|
* `/search` is included deliberately: the bar is the single md+ search input,
|
|
* so it must survive the hop onto the results page instead of being replaced by
|
|
* a second input belonging to that page. The library routes keep it because
|
|
* that is where a search is most often started.
|
|
*
|
|
* TRACES: UR-049, UR-054 | DR-063
|
|
*/
|
|
export function showHeaderSearch({ pathname }: { pathname: string }): boolean {
|
|
return pathname.startsWith("/library") || isSearchRoute(pathname);
|
|
}
|
|
|
|
/**
|
|
* Whether any bottom UI is showing for this route (mini player, nav, or both).
|
|
* The bottom UI is rendered in flex flow below the scroller (see BottomUi.svelte),
|
|
* so this is purely a visibility question — there is no padding to reserve.
|
|
*/
|
|
export function showBottomUi(input: BottomUiVisibilityInput): boolean {
|
|
return showBottomNav(input) || showGlobalMiniPlayer({ pathname: input.pathname });
|
|
}
|
|
|
|
/**
|
|
* Whether the app shell itself must reserve the bottom safe-area inset
|
|
* (`--safe-bottom`, i.e. the Android navigation/gesture bar).
|
|
*
|
|
* Exactly one element may reserve it. BottomUi owns it whenever it renders,
|
|
* because the padding belongs *inside* its surface box so the colour extends
|
|
* behind the bar rather than leaving a strip of page background. On routes with
|
|
* no bottom UI at all (login, the full-screen player) nothing else would, so
|
|
* the shell takes it.
|
|
*
|
|
* TRACES: UR-066 | DR-112
|
|
*/
|
|
export function shellReservesBottomInset(input: BottomUiVisibilityInput): boolean {
|
|
return !showBottomUi(input);
|
|
}
|